Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Issue template: Replace "host machine OS" by text appropriate for mobile devices #515

Merged
merged 16 commits into from
Jun 18, 2020

Conversation

gerritholl
Copy link
Contributor

@gerritholl gerritholl commented Jun 16, 2020

In the Github issue template, replace the "host machine OS" description to be more appropriate for mobile devices. Instead of mentioning Linux or Windows, ask the user to tell their Mobile device and Android version

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • If this PR comes from a fork, please Allow edits from maintainers
  • Set a speaking title. Format: {task_name} (closes #{issue_number}). For example: Use logger (closes # 41)
  • Link your Pull Request to an issue (if applicable)
  • Create Work In Progress [WIP] pull requests only if you need clarification or an explicit review before you can continue your work item.
  • Make sure that your PR is not introducing unnecessary reformatting (e.g., introduced by on-save hooks in your IDE)
  • Make sure that your PR does not contain changes in strings.xml (see issue [HELP WANTED][README] Text / Translations  #332)
  • Make sure that your PR does not contain compiled sources (already set by the default .gitignore) and / or binary files

Description

The github issue template for host machine OS was confusing and not relevant for mobile users, which means all users of cwa-app-android. Instead, ask for android version and smartphone model.

@gerritholl gerritholl requested a review from a team June 16, 2020 09:29
@gerritholl gerritholl changed the title Update "host machine OS" for mobile devices Github template: Replace "host machine OS" by line appropriate for mobile devices Jun 16, 2020
@gerritholl gerritholl changed the title Github template: Replace "host machine OS" by line appropriate for mobile devices Issue template: Replace "host machine OS" by text appropriate for mobile devices Jun 16, 2020
@marcmuschko marcmuschko changed the base branch from master to dev June 18, 2020 12:12
@marcmuschko marcmuschko merged commit 9993769 into corona-warn-app:dev Jun 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants