Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Fix Language Selection (closes #547) #692

Merged
merged 3 commits into from
Jun 22, 2020

Conversation

duchampdev
Copy link
Contributor

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • If this PR comes from a fork, please Allow edits from maintainers
  • Set a speaking title. Format: {task_name} (closes #{issue_number}). For example: Use logger (closes # 41)
  • Link your Pull Request to an issue (if applicable)
  • Create Work In Progress [WIP] pull requests only if you need clarification or an explicit review before you can continue your work item.
  • Make sure that your PR is not introducing unnecessary reformatting (e.g., introduced by on-save hooks in your IDE)
  • Make sure that your PR does not contain changes in strings.xml (see issue [HELP WANTED][README] Text / Translations  #332)
  • Make sure that your PR does not contain compiled sources (already set by the default .gitignore) and / or binary files

Description

This PR is meant to fix issue #547. Using appcompat introduces translations for some strings in languages that are not supported by the app. The result is that the app uses these strings from the systems primary language and falls back to the app's default language (English) for all other strings. Using the resConfigs in build.gradle removes all strings apart from the English and German ones. This way, also setups with multiple languages and German as secondary (or tertiary,...) language are supported (for Android >= 7, as multiple languages are only supported from Android 7 on).

restrict resource locales to "de" and "en" to properly to help Android respect language settings by user
@duchampdev duchampdev requested a review from a team June 20, 2020 21:54
@duchampdev duchampdev changed the base branch from master to dev June 20, 2020 21:54
@pr1metine
Copy link
Contributor

You need to push more changes to this PR to reinstantiate CI.

Copy link
Contributor

@harambasicluka harambasicluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@jakobmoellerdev jakobmoellerdev merged commit f2e9bbd into corona-warn-app:dev Jun 22, 2020
@pwoessner pwoessner mentioned this pull request Jul 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants