Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Remove blanket internet connection status (EXPOSUREAPP-1572) #1096

Merged
merged 6 commits into from
Sep 1, 2020

Conversation

Oliver-Zimmerman
Copy link
Contributor

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • If this PR comes from a fork, please Allow edits from maintainers
  • Set a speaking title. Format: {task_name} (closes #{issue_number}). For example: Use logger (closes # 41)
  • Link your Pull Request to an issue - Pull Requests that are not linked to an issue with you as an assignee will be closed, except for minor fixes for typos or grammar mistakes in documentation or code comments.
  • Create Work In Progress [WIP] pull requests only if you need clarification or an explicit review before you can continue your work item.
  • Make sure that your PR is not introducing unnecessary reformatting (e.g., introduced by on-save hooks in your IDE)
  • Make sure that your PR does not contain changes in text files, therefore the PR must not contain changes in values/strings/* and / or assets/* (see issue [HELP WANTED][README] Text / Translations  #332 for further information)
  • Make sure that your PR does not contain compiled sources (already set by the default .gitignore) and / or binary files

Description

Removed the blanket internet connection status:

Removed the connection state from TracingStatusHelper
Adjusted formatters which use the adjusted TracingStatusHelper
Removed connection logic from various fragments (SettingsTracingFragment, etc.)
Adjusted XML views (Settings Fragment: no connection card, etc.)
Adjusted automated tests that previously included the connection state.

Test:
Use application with mobile data and wifi turned off, exposure logging will still be active (visible in Main fragment and Settings Fragment). Separate dialogs for things like TAN and QR code scanning, where an internet connection is required, will mention there is no internet connection.

Closes JIRA task EXPOSUREAPP-1572

…ne issues

Removed the blanket internet connection status:

Removed the connection state from TracingStatusHelper
Adjusted formatters which use the adjusted TracingStatusHelper
Removed connection logic from various fragments (SettingsTracingFragment, etc.)
Adjusted XML views (Settings Fragment: no connection card, etc.)
Adjusted automated tests that previously included the connection state.
Closes JIRA task EXPOSUREAPP-1572
deviceForTesters was still using connection state.
@Oliver-Zimmerman Oliver-Zimmerman requested a review from a team September 1, 2020 11:05
@harambasicluka harambasicluka added maintainers Tag pull requests created by maintainers sprint5 labels Sep 1, 2020
Copy link
Contributor

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Project.xml

@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

62.3% 62.3% Coverage
0.0% 0.0% Duplication

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers sprint5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants