This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
1.3.1 into 1.4.0 #1177
Merged
1.3.1 into 1.4.0 #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dev 1.3.0 to RC/1.3.0
Dev 1.3.0 to RC/1.3.0
Dev 1.3.0 to RC/1.3.0
Hotfix 1.2.1
Dev 1.3.0 to RC/1.3.0
Dev 1.3.0 to RC/1.3.0
RC/1.3.0 to Master
Co-authored-by: harambasicluka <64483219+harambasicluka@users.noreply.github.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com>
…2) (#1106) * + new strings * let the app not crash on other languages than DE * values for lint and tests * made bad test a comment * removed unnecessary strings * more string fixes Co-authored-by: Jakob Möller <jakob.moeller@sap.com> Co-authored-by: Luka Harambasic <luka.harambasic@sap.com>
…APP-2405) (#1108) * Remove Cache Clearing to reduce CDN load on failing devices. This ideally needs to be accompanied by a way to clear the cache manually and a way to identify more root causes of Transaction Failures. Signed-off-by: d067928 <jakob.moeller@sap.com> * Remove Files that failed for Key Retrieval Only Remove Files from Cache that failed to download, instead of every file. This is accompanied ideally by no rollback in the Key Retrieval. We only delete the cache ref, the file will not be deleted as it is considered not present Signed-off-by: d067928 <jakob.moeller@sap.com> * Introduce dedicated QuotaCalculator for Unit Testing Signed-off-by: d067928 <jakob.moeller@sap.com> * Refactor QuotaCalculator for LocalData Property Access and Write Tests Signed-off-by: d067928 <jakob.moeller@sap.com> * Use Instant on the Device Read since this is not timezone specific Signed-off-by: d067928 <jakob.moeller@sap.com> * Add specific state for the quota calculation and dedicated rollback Signed-off-by: d067928 <jakob.moeller@sap.com> * PR Comments Signed-off-by: d067928 <jakob.moeller@sap.com>
Signed-off-by: d067928 <jakob.moeller@sap.com>
Change-Id: Ib76a9ea2b03163a05dd8b6acf2179262f9bcf5bf
…the Transaction (EXPOSUREAPP-2405) (#1134) * Throw Exception in case we have a failed entry to ensure Abortion of the Transaction. Signed-off-by: d067928 <jakob.moeller@sap.com> * Adjust test to not expect call to clear cache files Signed-off-by: d067928 <jakob.moeller@sap.com>
* Fix: No exposure with low risk so far * Fixed klint issues (#1144) * restored reverted replaced wording for lint * #1153 (comment) * fixed term
…ers, Correct Quota Tests due to now lacking exception Signed-off-by: d067928 <jakob.moeller@sap.com>
… merge/1.3.1-to-1.4.0 # Conflicts: # Corona-Warn-App/build.gradle # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/CoronaWarnApplication.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/transaction/RetrieveDiagnosisKeysTransaction.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/GoogleQuotaCalculator.kt # Corona-Warn-App/src/main/res/values-bg/strings.xml # Corona-Warn-App/src/main/res/values-pl/strings.xml # Corona-Warn-App/src/test/java/de/rki/coronawarnapp/util/GoogleQuotaCalculatorTest.kt
jakobmoellerdev
approved these changes
Sep 17, 2020
harambasicluka
approved these changes
Sep 17, 2020
BMItr
reviewed
Sep 17, 2020
| logWriter?.let { | ||
| try { | ||
| it.write("${System.currentTimeMillis()} ${priorityToString(priority)}/$tag: $message\n") | ||
| it.flush() |
There was a problem hiding this comment.
flushing is done after every logline. This happens usually in milliseconds and can penetrate storage memory. I would recommend to buffer in general but I think its ok for a temp solution.
|
Kudos, SonarCloud Quality Gate passed!
|
BMItr
reviewed
Sep 17, 2020
| } | ||
| } | ||
|
|
||
| override fun log(priority: Int, tag: String?, message: String, t: Throwable?) { |
There was a problem hiding this comment.
I would recommend to I/O async or in background thread...
BMItr
approved these changes
Sep 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the hotfix branch into our next RC.