Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Cannot delete tests older than 21 days - DE: Tests die älter als 21 Tage sind, können nicht gelöscht werden (EXPOSUREAPP-2398) #1481

Merged
merged 5 commits into from
Oct 26, 2020
Merged

Cannot delete tests older than 21 days - DE: Tests die älter als 21 Tage sind, können nicht gelöscht werden (EXPOSUREAPP-2398) #1481

merged 5 commits into from
Oct 26, 2020

Conversation

kolyaopahle
Copy link
Contributor

Description

This PR adds a new test status card to the homescreen to display when a test is older than 21 days and cant be requested from the backend anymore.
image
Pressing the card or the button will open the following dialog
image

Steps to reproduce

  1. Aquire an expired test and scan its qr code
  2. Navigate to the homescreen

@kolyaopahle
Added new card to show redeemed tests on the home screen
7bf1f50 
Signed-off-by: Kolya Opahle <k.opahle@sap.com>
@kolyaopahle
Fixed linting and unit tests
02f9b34 
Signed-off-by: Kolya Opahle <k.opahle@sap.com>
@kolyaopahle kolyaopahle added ui Issue related to UI aspects maintainers Tag pull requests created by maintainers labels Oct 26, 2020
@kolyaopahle kolyaopahle added this to the 1.6.0 milestone Oct 26, 2020
@kolyaopahle kolyaopahle requested a review from a team October 26, 2020 13:35
@kolyaopahle kolyaopahle mentioned this pull request Oct 26, 2020
Closed
@kolyaopahle kolyaopahle linked an issue Oct 26, 2020 that may be closed by this pull request
Can’t access test results b/c CWA is stuck at “Datenabruf” #1084
Closed
@harambasicluka harambasicluka added the prio PRs to review first. label Oct 26, 2020
ralfgehrer
ralfgehrer approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@ralfgehrer ralfgehrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works nicely

@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

37.5% 37.5% Coverage
0.0% 0.0% Duplication

@harambasicluka harambasicluka merged commit 21b7d77 into release/1.6.x Oct 26, 2020
@harambasicluka harambasicluka deleted the fix/2398-deletion-of-old-tests branch October 26, 2020 16:48
@MikeMcC399 MikeMcC399 mentioned this pull request Nov 8, 2020
Closed
@vaubaehn
Copy link
Contributor

vaubaehn commented Nov 11, 2020 •
edited
Loading

@kolyaopahle
Hi Kolya, do you have any idea why the fix doesn't seem to work in production for previously affected users?
The mood of some in #1084 after update to 1.6.0 is a little bit complicated right now...
Kind regards, v.

@MikeMcC399
Copy link
Contributor

#1084 is flagged as a hot topic and it would be good for the Open Source Team to respond urgently to the issues remaining in V1.6.0.

@kolyaopahle
Copy link
Contributor Author

I've reopened discussion in #1084 as this indeed does not seem to fix the underlying issue that people are having in production. Thank you for the heads up :)

@kolyaopahle kolyaopahle mentioned this pull request Nov 12, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ralfgehrer ralfgehrer ralfgehrer approved these changes

@SabineLoss SabineLoss SabineLoss approved these changes

@harambasicluka harambasicluka harambasicluka approved these changes

@janetback janetback Awaiting requested review from janetback

Assignees
No one assigned
Labels
maintainers Tag pull requests created by maintainers prio PRs to review first. ui Issue related to UI aspects
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

Can’t access test results b/c CWA is stuck at “Datenabruf”
6 participants
@kolyaopahle @vaubaehn @MikeMcC399 @ralfgehrer @SabineLoss @harambasicluka