Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Hide keyboard on CJ note editing when day view is closed (EXPOSUREAPP-5887) #2675

Merged
merged 9 commits into from
Mar 26, 2021

Conversation

ralfgehrer
Copy link
Contributor

Steps:

  • create person or location
  • on the day view edit the note for day or location
  • during edit, leave the day view by pressing back in top-left corner

Expected result:

  • the keyboard gets dismissed

@ralfgehrer ralfgehrer added bug Something isn't working maintainers Tag pull requests created by maintainers labels Mar 23, 2021
@ralfgehrer ralfgehrer added this to the 2.0.0 milestone Mar 23, 2021
@ralfgehrer ralfgehrer requested a review from a team March 23, 2021 10:36
@harambasicluka harambasicluka self-assigned this Mar 25, 2021
Copy link
Contributor

@harambasicluka harambasicluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 🚀

OnePlus 8 Pro (Android 11)

@sonarcloud
Copy link

sonarcloud bot commented Mar 26, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kolyaopahle kolyaopahle self-assigned this Mar 26, 2021
Copy link
Contributor

@kolyaopahle kolyaopahle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also worked on my pixel 5 👍

@ralfgehrer ralfgehrer merged commit 09afabb into release/2.0.x Mar 26, 2021
@ralfgehrer ralfgehrer deleted the fix/5887-hide-keyboard-on-notes branch March 26, 2021 16:32
@vaubaehn
Copy link
Contributor

vaubaehn commented Mar 26, 2021

Hi,
@ralfgehrer explicitly triggered the open keyboard by pressing top-left back.
Did you check whether the fix also works, when you finished editing the note, and then change the focus to a different person or location by marking/activating the object? In my opinion the keyboard should also be closed in these cases (which is not the case in 1.15.x)

Also, when you test this, you might be able to trigger our good old friend 9002: activate/select person or location, tap into note field, press del on keyboard, unselect person/location. Please leave me a note whether you can reproduce 9002 npe, or if i should create an issue for this.
Edit: 9002 was now reported by someone else, see #2703

Cheers and good night,
V.

@ralfgehrer
Copy link
Contributor Author

Many thanks for the feedback @vaubaehn.
I'll tackle this as part of #2703 then.

@ralfgehrer
Copy link
Contributor Author

Hi @vaubaehn, I addressed the issue in this PR: #2715

@vaubaehn
Copy link
Contributor

Hi @ralfgehrer , thanks a lot for taking care and for giving information.
I'm wishing nice Easter Holidays to you and all the Dev-Team!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants