This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 496
Fix exception when deselecting person (EXPOSUREAPP-6003) #2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralfgehrer
added
bug
Something isn't working
maintainers
Tag pull requests created by maintainers
labels
Mar 30, 2021
ralfgehrer
changed the title
Fix exception when deselecting person w/ focused notes (EXPOSUREAPP-6003)
Fix exception when deselecting person (EXPOSUREAPP-6003)
Mar 30, 2021
This was referenced Mar 30, 2021
Closed
I ran through the repro steps from issue #2703 :
on the same device mentioned in the issue report (Samsung Galaxy A5 2017 with Android 8) and there is no longer an error with the fix in this PR. I also successfully checked on a Google Pixel 3a emulator with Android 11. |
harambasicluka
approved these changes
Mar 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested on Xiamo Mi 9 (Android 9) 🎉
kolyaopahle
reviewed
Mar 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
kolyaopahle
approved these changes
Mar 31, 2021
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to test
Expected result:
Additional Remarks:
When editing notes, the soft keyboard shows up. If another entry (e.g. duration) is edited afterward, the soft keyboard should be hidden.