Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Fix exception when deselecting person (EXPOSUREAPP-6003) #2715

Merged
merged 8 commits into from
Mar 31, 2021

Conversation

ralfgehrer
Copy link
Contributor

@ralfgehrer ralfgehrer commented Mar 30, 2021

Steps to test

  • Open locations or persons
  • Select an existing item
  • Click in the notes field, so the cursor is shown
  • Deselect the person or location, selected in step 2

Expected result:

  • No exception

Additional Remarks:
When editing notes, the soft keyboard shows up. If another entry (e.g. duration) is edited afterward, the soft keyboard should be hidden.

@ralfgehrer ralfgehrer added bug Something isn't working maintainers Tag pull requests created by maintainers labels Mar 30, 2021
@ralfgehrer ralfgehrer added this to the 2.0.0 milestone Mar 30, 2021
@ralfgehrer ralfgehrer requested a review from a team March 30, 2021 10:14
@ralfgehrer ralfgehrer changed the title Fix exception when deselecting person w/ focused notes (EXPOSUREAPP-6003) Fix exception when deselecting person (EXPOSUREAPP-6003) Mar 30, 2021
@harambasicluka harambasicluka self-assigned this Mar 30, 2021
@MikeMcC399
Copy link
Contributor

I ran through the repro steps from issue #2703 :

  1. Open locations or persons
  2. Select an existing item
  3. Klick in the notes field, so the cursor is shown
  4. Deselect the person or location, selected in step 2

on the same device mentioned in the issue report (Samsung Galaxy A5 2017 with Android 8) and there is no longer an error with the fix in this PR. I also successfully checked on a Google Pixel 3a emulator with Android 11.

Copy link
Contributor

@harambasicluka harambasicluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on Xiamo Mi 9 (Android 9) 🎉

@kolyaopahle kolyaopahle self-assigned this Mar 31, 2021
Copy link
Contributor

@kolyaopahle kolyaopahle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ralfgehrer ralfgehrer merged commit f315aee into release/2.0.x Mar 31, 2021
@ralfgehrer ralfgehrer deleted the fix/6003-npe-cj branch March 31, 2021 12:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants