Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

QR Code Poster (EXPOSUREAPP-5962) #2727

Merged
merged 108 commits into from
Apr 7, 2021
Merged

QR Code Poster (EXPOSUREAPP-5962) #2727

merged 108 commits into from
Apr 7, 2021

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Mar 31, 2021 •
edited
Loading

  • Create location poster PDF
  • Enable printing , Sharing
  • Delete testing screens, Please use the actual screens

Testing

  • Test against mock server
  • Create location -> Choose Print option from overflow menu
  • Create location -> QR Code details screen -> Print button
  • Check poster and try printing and sharing

TODO

  • Finalise positioning values from server
  • Text Box font - not provided yet
  • Create poster on the fly (New ticket 🎫 probably or even after MVP)

After merging #2737

  • Use Location Url to generate QR Code
  • Extend testability for TraceLocation

LukasLechnerDev and others added 30 commits March 24, 2021 10:55
@LukasLechnerDev
Move CreateTraceLocationApiV1.kt and TraceLocationServer.kt into new …
915d690 
…sub-package
@LukasLechnerDev
Move CreateTraceLocation DI logic into sub-package
0554583
@LukasLechnerDev
Create infrastructure code for new Qr-Code Poster Template Endpoint
5dfe66a
@LukasLechnerDev
Add new url to environment
31dd5d7
@LukasLechnerDev
Show new URL in the Test Menu
cf0df46
@LukasLechnerDev
Implement unzipping, signature verification and parsing
425744f
@LukasLechnerDev
Add possibility to download poster template from TestMenu
909b1a4
@LukasLechnerDev
Show Android Vector Drawable in TestMenu
fb6931e
@LukasLechnerDev
Create QrCodePosterTemplateApiV1Test.kt
102a7b4
@LukasLechnerDev
Remove non-used ProtoConverter from retrofit
ea787b8
@LukasLechnerDev
Change button position in Test Fragment
9b7a6be
@LukasLechnerDev
Merge branch 'release/2.0.x' into feature/5842-Poster-template-downlo…
43addfb 
…ad-and-storage

# Conflicts:
#	Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/eventregistration/ui/qrcode/QrCodeCreationTestViewModel.kt
@LukasLechnerDev
Show error if something goes wrong
1b00f21
@LukasLechnerDev
Improve QrCodePosterTemplateApiV1Test.kt
aa6583a
@LukasLechnerDev
Create QrCodePosterTemplateServerTest.kt
1c39cc2
@LukasLechnerDev
Merge branch 'release/2.0.x' into feature/5842-Poster-template-downlo…
963e05c 
…ad-and-storage
@harambasicluka
Merge branch 'release/2.0.x' into feature/5842-Poster-template-downlo…
a2d4604 
…ad-and-storage
@mtwalli
Merge branch 'release/2.0.x' into feature/5842-Poster-template-downlo…
178ad5f 
…ad-and-storage
@harambasicluka
Merge branch 'release/2.0.x' into feature/5842-Poster-template-downlo…
8eb4ede 
…ad-and-storage
@mtwalli
Initial setup
6f461cd
@mtwalli
Merge branch 'release/2.0.x' into feature/5842-Poster-template-downlo…
e45e4d1 
…ad-and-storage
@mtwalli
Merge branch 'release/2.0.x' into feature/5842-Poster-template-downlo…
d6a93bc 
…ad-and-storage
@mtwalli
Merge branch 'feature/5842-Poster-template-download-and-storage' into…
c597bff 
… feature/5962-pdf-poster
@mtwalli
Merge branch 'release/2.0.x' into feature/5962-pdf-poster
73ce7e2
@mtwalli
Connect flow to poster
0864ff6
@mtwalli
Fix flow connection
5f8c71e
@mtwalli
Nice transition
933fafe
@mtwalli
Lint
f71432d
@mtwalli
Allow nullable extras
94abecf
@mtwalli
Adjust icon tint
68439ff
@harambasicluka harambasicluka added the prio PRs to review first. label Apr 7, 2021
@LukasLechnerDev LukasLechnerDev self-assigned this Apr 7, 2021
@axelherbstreith
Copy link
Contributor

Tested it on different screen size (4.5, 5.7 and 6.3"). Looks really impressive! 💯

image

@LukasLechnerDev
Copy link
Contributor

Looks very good on my Pixel 3A and Samsung S20+, both Android 11.

Great work 🚀

LukasLechnerDev
LukasLechnerDev previously approved these changes Apr 7, 2021
View reviewed changes
@axelherbstreith axelherbstreith self-assigned this Apr 7, 2021
axelherbstreith
axelherbstreith previously approved these changes Apr 7, 2021
View reviewed changes
janetback
janetback reviewed Apr 7, 2021
View reviewed changes
Corona-Warn-App/src/main/res/values-de/strings.xml Outdated
<!-- XMIT: Trace location poster print -->
<string name="trace_location_organiser_poster_print">"Drucken"</string>
<!-- XMIT: Trace location poster share -->
<string name="trace_location_organiser_poster_share">"Share"</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to "Teilen". Thanks.

@axelherbstreith axelherbstreith dismissed stale reviews from LukasLechnerDev and themself via 32071d4 April 7, 2021 11:28
janetback
janetback approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@janetback janetback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved.

@sonarcloud
Copy link

sonarcloud bot commented Apr 7, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

9.5% 9.5% Coverage
0.0% 0.0% Duplication

@harambasicluka harambasicluka merged commit 53cf44c into release/2.0.x Apr 7, 2021
@harambasicluka harambasicluka deleted the feature/5962-pdf-poster branch April 7, 2021 11:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@axelherbstreith axelherbstreith axelherbstreith approved these changes

@janetback janetback janetback approved these changes

@LukasLechnerDev LukasLechnerDev LukasLechnerDev left review comments

Assignees

@LukasLechnerDev LukasLechnerDev

@axelherbstreith axelherbstreith

Labels
maintainers Tag pull requests created by maintainers prio PRs to review first. text change PRs with text changes. ui Issue related to UI aspects
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mtwalli @axelherbstreith @LukasLechnerDev @janetback @harambasicluka