This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Trace Location URL and ID (EXPOSUREAPP-6137, EXPOSUREAPP-6182) #2737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtwalli
changed the title
3 tasks
...rn-App/src/main/java/de/rki/coronawarnapp/eventregistration/checkins/qrcode/TraceLocation.kt
Show resolved
Hide resolved
...n/java/de/rki/coronawarnapp/ui/eventregistration/attendee/confirm/ConfirmCheckInViewModel.kt
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/ProtoBuff.kt
Outdated
Show resolved
Hide resolved
LukasLechnerDev
previously approved these changes
Apr 6, 2021
d4rken
reviewed
Apr 6, 2021
...-App/src/main/java/de/rki/coronawarnapp/eventregistration/checkins/qrcode/QRCodeUriParser.kt
Outdated
Show resolved
Hide resolved
...-App/src/main/java/de/rki/coronawarnapp/eventregistration/checkins/qrcode/QRCodeUriParser.kt
Outdated
Show resolved
Hide resolved
| @@ -95,7 +91,8 @@ class PresenceTracingConfigMapper @Inject constructor() : PresenceTracingConfig. | |||
| revokedTraceLocationVersions = revokedTraceLocationVersionsList.orEmpty(), | |||
| riskCalculationParameters = riskCalculationParameters, | |||
| submissionParameters = submissionParameters, | |||
| plausibleDeniabilityParameters = plausibleDeniabilityParameters | |||
| plausibleDeniabilityParameters = plausibleDeniabilityParameters, | |||
| qrCodeDescriptors = qrCodeDescriptorsOrBuilderList | |||
There was a problem hiding this comment.
Should we evaluate here whether the qrCodeDescribtor is actually valid regex?, and if it is not valid regex, throw an exception to fallback to a different config?
There was a problem hiding this comment.
I did not see any specs for that. Can you align with Max first? The regex in this case is dynamic I don't know how do you want to check if valid or not ?
There was a problem hiding this comment.
Just compile it, if it is not valid regex, it would throw an exception? /cc @mlenkeit
There was a problem hiding this comment.
Let's merge it as is and do a follow up if necessary.
harambasicluka
changed the title
LukasLechnerDev
approved these changes
Apr 6, 2021
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
Change
qrCodeDescriptorsfrom configs and support Base64 and Base32 encoding validationTesting
Last Organiser LocationLast Attendee Location(ChecKIn) with the same data above , since Location is the same of organiser and attendee , the data should be exactly the same except theidwhich is Table specific. Data should varies in case you scanned another location which will come next by QR Code Poster (EXPOSUREAPP-5962) #2727 .Please note that url validation supports both Base32 and Base64 ,but the not the creation which supports only Base64