Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

NFC #2978

Closed
wants to merge 1 commit into from
Closed

NFC #2978

wants to merge 1 commit into from

Conversation

ElishaDev
Copy link

Changed the AndroidManifest.xml to support the possibility to scan an NFC-Tag with a CheckIn-URL to open the app directly like in the iOS version.

Changed the AndroidManifest.xml to support the possibility to scan an NFC-Tag with a CheckIn-URL to open the App directly like in the iOS Version.
@ElishaDev ElishaDev requested a review from a team April 27, 2021 15:40
@d4rken d4rken added the community Tag issues created by community members label Apr 27, 2021
@d4rken
Copy link
Member

d4rken commented Apr 27, 2021

Thanks for the contribution, unfortunately you didn't seem to have read the contribution template 😦 ?

At the least we'd need a corresponding issue ticket, to discuss your idea with both the community, and mirror it to our JIRA to discuss internally with other involved parties.

Other community PR examples: https://github.com/corona-warn-app/cwa-app-android/pulls?q=is%3Apr+label%3Acommunity+is%3Aclosed

In any case, directly merging into main would not be possible, we'd have to target one of the upcoming releases, as 2.1 almost has dev close, it would be 2.2.

Checklist below:


Checklist

Thank you for this this PR! Please consider the following:

  • To the Community ❤️:
    • Please link to an issue ticket where your code change has been greenlit, otherwise it's unlikely it can be merged.
    • Use a descriptive title: {task_name} (closes #{issue_number}), e.g.: Use logger (closes # 41).
    • If this PR comes from a fork, please Allow edits from maintainers
    • The PR can not contain changes in localization files, e.g. values-[LANGUAGE-CODE]/strings/* and / or assets/* (see #332 for further information).
  • To the Maintainers ☕:
    • Title structure: Jira ticket name (EXPOSUREAPP-XXXX).
    • Set labels: maintainers, sprintX.
    • Update Jira status: In Review.
    • Fulfill internal Acceptance Criteria.
    • If mentioned in the Jira ticket link all corresponding GitHub issues in the sidebar.
  • To everyone 🗺️:
    • Describe your changes in detail, if you changed the UI, screenshots or GIFs would be awesome!
    • Short step by step instructions help the reviewer test your changes, e.g. how to navigate to a new UI element you added.
    • The PR won't be reviewed if CircleCi is failing or if there are merge conflicts. If Circle CI is still failing mark the PR as a draft and write a little comment on your status.
    • Provide at least a few unit and/or instrumentation tests.
    • Use a meaning full branch name. Use either fix or feature as prefix for your branch, e.g. fix/prevent-npe-on-device-rotation-issue_123
    • Test your changes thoroughly. Only open PRs which you think is ready to be merged. If you explicitly need feedback mark the PR as DRAFT on Github.
    • Don't introduce unrelated code reformatting (e.g., on-save hooks in your IDE)
    • Remove this checklist before creating your pull request.

Description

Steps to reproduce

@d4rken d4rken closed this Apr 27, 2021
@ElishaDev ElishaDev deleted the patch-1 branch April 27, 2021 16:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community Tag issues created by community members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants