Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Refresh versions (COMMUNITY) #3167

Closed
wants to merge 2 commits into from

Conversation

jmfayard
Copy link

@jmfayard jmfayard commented May 13, 2021

Checklist

Thank you for this this PR! Please consider the following:

  • To the Community ❤️:
    • Please link to an issue ticket where your code change has been greenlit, otherwise it's unlikely it can be merged.
    • Use a descriptive title: {task_name} (closes #{issue_number}), e.g.: Use logger (closes # 41).
    • If this PR comes from a fork, please Allow edits from maintainers
    • The PR can not contain changes in localization files, e.g. values-[LANGUAGE-CODE]/strings/* and / or assets/* (see #332 for further information).
  • To the Maintainers ☕:
    • Title structure: Jira ticket name (EXPOSUREAPP-XXXX).
    • Set labels: maintainers, sprintX.
    • Update Jira status: In Review.
    • Fulfill internal Acceptance Criteria.
    • If mentioned in the Jira ticket link all corresponding GitHub issues in the sidebar.
  • To everyone 🗺️:
    • Describe your changes in detail, if you changed the UI, screenshots or GIFs would be awesome!
    • Short step by step instructions help the reviewer test your changes, e.g. how to navigate to a new UI element you added.
    • The PR won't be reviewed if CircleCi is failing or if there are merge conflicts. If Circle CI is still failing mark the PR as a draft and write a little comment on your status.
    • Provide at least a few unit and/or instrumentation tests.
    • Use a meaningful branch name. Use either fix or feature as prefix for your branch, e.g. fix/prevent-npe-on-device-rotation-issue_123
    • Test your changes thoroughly. Only open PRs which you think is ready to be merged. If you explicitly need feedback mark the PR as DRAFT on GitHub.
    • Don't introduce unrelated code reformatting (e.g., on-save hooks in your IDE)
    • Remove this checklist before creating your pull request.

Description

Add gradle refreshVersions to make adding and updating dependencies easier

Steps to reproduce


Internal Tracking ID: EXPOSUREAPP-7289

@jmfayard jmfayard requested a review from a team May 13, 2021 07:59
@ralfgehrer ralfgehrer changed the title Refresh versions Refresh versions (COMMUNITY) May 14, 2021
@ralfgehrer ralfgehrer added the community Tag issues created by community members label May 14, 2021
@dsarkar
Copy link
Member

dsarkar commented May 14, 2021

Internal Tracking ID: EXPOSUREAPP-7289

@dsarkar dsarkar added the mirrored-to-jira This item is also tracked internally in JIRA label May 14, 2021
@dsarkar dsarkar assigned dsarkar and unassigned dsarkar May 14, 2021
@d4rken d4rken self-assigned this May 17, 2021
@d4rken
Copy link
Member

d4rken commented May 17, 2021

Thanks for the PR, but we can't merge this:

  • You didn't read the PR template?
  • We generally only refresh libraries if there is a bugfix or feature we want.
  • Just updating for the sake of it can introduce new bugs and requires additional testing effects to make sure the dependency upgrade did not break anything.
  • Dependency upgrades can require additional changes in our internal pipeline, where newer versions have to be greenlight before being able to use them. So cost/benefit needs to be right for a dependency upgrade.
  • This seems a bit like self advertisement for your refreshVersions plugin?

@d4rken d4rken closed this May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community Tag issues created by community members mirrored-to-jira This item is also tracked internally in JIRA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants