Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Delay for Diagnosis Keys retrieval set to 2 hours (contributes to corona-warn-app/cwa-documentation#236) #452

Closed

Conversation

kbobrowski
Copy link
Contributor

@kbobrowski kbobrowski commented Jun 14, 2020

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • If this PR comes from a fork, please Allow edits from maintainers
  • Set a speaking title. Format: {task_name} (closes #{issue_number}). For example: Use logger (closes # 41)
  • Link your Pull Request to an issue (if applicable)
  • Create Work In Progress [WIP] pull requests only if you need clarification or an explicit review before you can continue your work item.
  • Make sure that your PR is not introducing unnecessary reformatting (e.g., introduced by on-save hooks in your IDE)
  • Make sure that your PR does not contain changes in strings.xml (see issue [HELP WANTED][README] Text / Translations  #332)
  • Make sure that your PR does not contain compiled sources (already set by the default .gitignore) and / or binary files

Description

Currently Diagnosis Keys are only fetched every 24 hours, which introduces additional 24 hours delay in exposure notification in a worst-case scenario (last synchronization performed just before relevant Diagnosis Key became available). Decreasing this value to 2 hours also decreases introduced delay to 2 hours in worst-case, and aligns Android implementation with current iOS implementation.

Contributes to corona-warn-app/cwa-documentation#236

this decreases introduced delay in exposure notification, and aligns
this value with a value used in iOS implementation
@kbobrowski kbobrowski requested a review from a team June 14, 2020 10:13
@kbobrowski kbobrowski changed the title Delay for Diagnosis Keys retrieval set to 2 hours (contributes to #451) Delay for Diagnosis Keys retrieval set to 2 hours (contributes to corona-warn-app/cwa-documentation#236) Jun 14, 2020
@jakobmoellerdev
Copy link
Contributor

Hi! Since Hourly Fetching is not supported yet due to lack of batching as well as the necessity to persist the token for actually combining the results of provideDiagnosisKeys, this PR will not be merged for a while.

If batching gets introduced and the hourly fetching is properly introduced we will instead reintroduce some of the code that was previously implemented but removed before release due to the mentioned lack of batching. Most of that code is equivalent to your PR suggestion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants