Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Request COVID-Certificate has wrong text(normal) #4798

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

CV113
Copy link
Contributor

@CV113 CV113 commented Feb 8, 2022

Replace "Testergebnis" by "Testzertifikat"

--> https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-11602

Checklist

Thank you for this this PR! Please consider the following:

  • To the Community ❤️:
    • Please link to an issue ticket where your code change has been greenlit, otherwise it's unlikely it can be merged.
    • Use a descriptive title: {task_name} (closes #{issue_number}), e.g.: Use logger (closes # 41).
    • If this PR comes from a fork, please Allow edits from maintainers
    • The PR can not contain changes in localization files, e.g. values-[LANGUAGE-CODE]/strings/* and / or assets/* (see #332 for further information).
  • To the Maintainers ☕:
    • Title structure: Jira ticket name (EXPOSUREAPP-XXXX).
    • Set labels: maintainers, sprintX.
    • Update Jira status: In Review.
    • Fulfill internal Acceptance Criteria.
    • If mentioned in the Jira ticket link all corresponding GitHub issues in the sidebar.
  • To everyone 🗺️:
    • Describe your changes in detail, if you changed the UI, screenshots or GIFs would be awesome!
    • Short step by step instructions help the reviewer test your changes, e.g. how to navigate to a new UI element you added.
    • The PR won't be reviewed if CircleCi is failing or if there are merge conflicts. If Circle CI is still failing mark the PR as a draft and write a little comment on your status.
    • Provide at least a few unit and/or instrumentation tests.
    • Use a meaningful branch name. Use either fix or feature as prefix for your branch, e.g. fix/prevent-npe-on-device-rotation-issue_123
    • Test your changes thoroughly. Only open PRs which you think is ready to be merged. If you explicitly need feedback mark the PR as DRAFT on GitHub.
    • Don't introduce unrelated code reformatting (e.g., on-save hooks in your IDE)
    • Remove this checklist before creating your pull request.

Description

Steps to reproduce

@CV113 CV113 added the text change PRs with text changes. label Feb 8, 2022
@CV113 CV113 added this to the 2.18.0 milestone Feb 8, 2022
@CV113 CV113 requested review from KathrinLuecke and a team February 8, 2022 12:07
@sonarcloud
Copy link

sonarcloud bot commented Feb 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mtwalli mtwalli merged commit 0ba809a into release/2.18.x Feb 8, 2022
@mtwalli mtwalli deleted the Request-COVID-Certificate-has-wrong-text branch February 8, 2022 13:41
Copy link
Contributor

@KathrinLuecke KathrinLuecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
text change PRs with text changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants