Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Add padding on bottom of certificate cards (EXPOSUREAPP-13193) #5254

Merged
merged 2 commits into from
Jun 3, 2022

Conversation

SamuraiKek
Copy link
Contributor

Ticket

Cards will always have a 14dp padding on the bottom now. To reproduce the bug, I had to scan multiple certs for the same person and increase the font size so the texts will no longer fit one row.

@SamuraiKek SamuraiKek added bug Something isn't working maintainers Tag pull requests created by maintainers labels Jun 2, 2022
@SamuraiKek SamuraiKek added this to the 2.24.x milestone Jun 2, 2022
@SamuraiKek SamuraiKek requested a review from a team June 2, 2022 09:58
@github-actions
Copy link

github-actions bot commented Jun 2, 2022

Unit Test Results - Device Release

   555 files  ±0     555 suites  ±0   6m 30s ⏱️ +22s
2 736 tests ±0  2 736 ✔️ ±0  0 💤 ±0  0 ±0 
2 785 runs  ±0  2 785 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 8d341a3. ± Comparison against base commit e3b5f9a.

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

Unit Test Results - Device For Tester Release

   558 files  ±0     558 suites  ±0   6m 32s ⏱️ +53s
2 742 tests ±0  2 742 ✔️ ±0  0 💤 ±0  0 ±0 
2 791 runs  ±0  2 791 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 8d341a3. ± Comparison against base commit e3b5f9a.

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

Firebase Test Results

    2 files  ±0      2 suites  ±0   5m 5s ⏱️ + 1m 3s
129 tests ±0  129 ✔️ ±0  0 💤 ±0  0 ±0 
258 runs  ±0  258 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 8d341a3. ± Comparison against base commit e3b5f9a.

@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mtwalli mtwalli merged commit 4de49fb into release/2.24.x Jun 3, 2022
@mtwalli mtwalli deleted the fix/13193 branch June 3, 2022 09:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants