This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 496
Add an animated exposure notification status icon #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit tests are currently failing
kolyaopahle
added
ui
Issue related to UI aspects
maintainers
Tag pull requests created by maintainers
labels
Jun 26, 2020
harambasicluka
suggested changes
Jul 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
harambasicluka
suggested changes
Jul 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide tests for Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/DataBindingAdapters.kt
The bugs where caused by a build variant which didn't included the animated icon. The contrast of the animation has to be confirmed by the designers, otherwise it looks good! 💯 |
harambasicluka
approved these changes
Jul 2, 2020
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This PR adds infrasturcture for animated icons and and also adds a first icon for the exposure status