Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Add an animated exposure notification status icon #757

Merged
merged 13 commits into from
Jul 2, 2020

Conversation

kolyaopahle
Copy link
Contributor

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • If this PR comes from a fork, please Allow edits from maintainers
  • Set a speaking title. Format: {task_name} (closes #{issue_number}). For example: Use logger (closes # 41)
  • Link your Pull Request to an issue - Pull Requests that are not linked to an issue with you as an assignee will be closed, except for minor fixes for typos or grammar mistakes in documentation or code comments.
  • Create Work In Progress [WIP] pull requests only if you need clarification or an explicit review before you can continue your work item.
  • Make sure that your PR is not introducing unnecessary reformatting (e.g., introduced by on-save hooks in your IDE)
  • Make sure that your PR does not contain changes in text files, therefore the PR must not contain changes in values/strings/* and / or assets/* (see issue [HELP WANTED][README] Text / Translations  #332 for further information)
  • Make sure that your PR does not contain compiled sources (already set by the default .gitignore) and / or binary files

Description

This PR adds infrasturcture for animated icons and and also adds a first icon for the exposure status

@kolyaopahle kolyaopahle added ui Issue related to UI aspects maintainers Tag pull requests created by maintainers labels Jun 26, 2020
Copy link
Contributor

@harambasicluka harambasicluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a Nokia 7.1 with Android 10 I get the following results:

image

image

Could you please resolve that?

Copy link
Contributor

@harambasicluka harambasicluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide tests for Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/DataBindingAdapters.kt

@harambasicluka
Copy link
Contributor

The bugs where caused by a build variant which didn't included the animated icon.

The contrast of the animation has to be confirmed by the designers, otherwise it looks good! 💯

@sonarcloud
Copy link

sonarcloud bot commented Jul 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@jakobmoellerdev jakobmoellerdev merged commit 728c248 into dev Jul 2, 2020
@jakobmoellerdev jakobmoellerdev deleted the feature/animated-icons branch July 2, 2020 13:40
@pwoessner pwoessner mentioned this pull request Jul 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers ui Issue related to UI aspects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants