Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAQ: Effect of clear data on random ID storage #1067

Closed
MikeMcC399 opened this issue Apr 11, 2021 · 4 comments
Closed

FAQ: Effect of clear data on random ID storage #1067

MikeMcC399 opened this issue Apr 11, 2021 · 4 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@MikeMcC399
Copy link
Contributor

Where to find the issue

Are the exposure logs/random IDs removed from my phone when I uninstall the app?
https://www.coronawarn.app/en/faq/#delete_random_ids

Werden die gesammelten Zufalls-IDs beim Deinstallieren der App entfernt?
https://www.coronawarn.app/de/faq/#delete_random_ids

Describe the issue

The FAQs misleadingly say:
"We recommend that before you re-install the app, you try clearing the app data first as this will not delete the random IDs:"

"Wir empfehlen daher, vor der Neu-installation zunächst die Daten in der App zurückzusetzen, da hierbei die gesammelten Zufalls-IDs nicht gelöscht werden:"

The FAQs mean resetting the app, not clearing the app data using the operating system UI.

The side-effect of using Android's "Clear data" storage maintenance function on the App listed as "Corona-Warn" is not explicitly mentioned. "Clear data" acts like uninstalling the app as far as the Google Exposure Notifications System is concerned. Keys will be deleted.

Background

In an old post corona-warn-app/cwa-app-android#642 (comment) from on Oct 30, 2020 @thomasaugsten wrote:

I doubled check and it looks Google is now registering the data deleting and turns off the exposure notification framework the leads to a key wiping. We will update our FAQ

From the context of the issue corona-warn-app/cwa-app-android#642 it seems that the FAQ being referred to was https://www.coronawarn.app/en/faq/#delete_random_ids.

The intention of updating the FAQ stated by @thomasaugsten was never actioned.

The general issue of the side-effects of deleting the data from the CWA on Android has been brought up in corona-warn-app/cwa-app-android#2795.

Suggested change

EN

Are the exposure logs/random IDs removed from my phone when I uninstall the app?

Reword:

"On Android devices, the current implementation deletes the 'database and keys' from the device when uninstalling the app. Hence, you should expect that the collected random IDs are deleted when the app is uninstalled. Random IDs are also deleted if the Android App storage maintenance "Clear data" function is used on the App "Corona-Warn"."

...

"We recommend that before you re-install the app, you try resetting the app first as this will not delete the random IDs:"

DE

Werden die gesammelten Zufalls-IDs beim Deinstallieren der App entfernt?

Reword:

"Auf Android-Geräten werden in der derzeitigen Implementierung beim Deinstallieren 'Datenbank und Schlüssel' vom Gerät gelöscht. Sie sollten daher davon ausgehen, dass mit Deinstallation der App auch die Begegnungsaufzeichnungen verloren gehen. Die Begegnungsaufzeichnungen gehen ebenso verloren, sollte die Android App-Speicherplatzverwaltungsfunktion "Daten löschen" auf die App "Corona-Warn" angewandt werden.

...

"Wir empfehlen daher, vor der Neu-installation zunächst die App zurückzusetzen, da hierbei die gesammelten Zufalls-IDs nicht gelöscht werden:"


I will put the above into a draft PR later today.

@MikeMcC399 MikeMcC399 added the bug Something isn't working label Apr 11, 2021
@MikeMcC399 MikeMcC399 changed the title Effect of clear data on random ID storage FAQ: Effect of clear data on random ID storage Apr 11, 2021
@MikeMcC399
Copy link
Contributor Author

I have created the PR #1068 and it is ready for review.

@MikeMcC399
Copy link
Contributor Author

@heinezen
Could you please review PR #1068? I'm unsure if the FAQ should go into the detail of what happens if a user deletes app data using Android tools. Perhaps we should close this PR instead of merging it?

@heinezen
Copy link
Member

@MikeMcC399

I have taken a look and don't see anything that would be problematic.

However, it got me thinking whether this FAQ entry takes the right approach in general. The question is: Who is the audience for this entry?

  1. Someone who wants solve a problem with the app and considers re-installing it?
  2. Someone who has uninstalled the app and wants to be sure that all the app's data (including exposue logs) are deleted?

Maybe it would be better to address both of these audiences individually with two separate entries:

  • What happens if I uninstall the app?
  • How do I delete all data gathered by the app?

@MikeMcC399
Copy link
Contributor Author

@heinezen

Thanks for taking a look!

The current FAQ
Are the exposure logs/random IDs removed from my phone when I uninstall the app?
https://www.coronawarn.app/en/faq/#delete_random_ids

answers more the question: "What happens if I uninstall the app?"

whereas the other question: "How do I delete all data gathered by the app?" is not specifically addressed.

I don't see much discussion in the last months about these topics however, so before spending additional time on this subject area at this stage in the app's life-cycle, I suggest either merging PR #1068 or closing it. I am fine with either decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants