-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android clear data function effects on Random IDs (closes #1067) #1068
Conversation
I also corrected three typos in the sentence: I changed "sie" to "Sie" and added a full-stop at the end of the sentence. |
Just one point: Would it make sense to add information at the end of the section, that installing (and activating) another ENS-based contact tracing app (like Immuni and alike) before uninstalling CWA or deleting its data, prevents 'Random IDs' to be erased? So that this method could be used as a last resort in case of non-functional CWA without losing RPIs/TEKs? |
This PR does not change the use of the terms "Begegnungsaufzeichnungen" and "Zufalls-IDs". The use is consistent with the definition in the app under Startseite > Dreipunkte-Symbol > Überblick
The Open Source Team decided in #320 to remove this information from the FAQ because it was not documented by Google. So, in summary I don't plan further changes and I would be happy for this PR to be merged. |
@MikeMcC399
... and probably more, which I couldn't spot within a quick research. What I was proposing to change, was to replace the 'Zufalls-IDs' in the sixth paragraph with 'Begegnungsaufzeichnungen' to have the same wording throughout the whole section. I felt irritated by the change of naming RPIs from 'Begegnungsaufzeichnungen' to 'Zufalls-IDs', and needed to think (again) if both words are meaning the same thing. I guess that a less technically advanced user might have even more problems to understand, what is talked about. Yes, you're right, there is a definition inside the CWA app, but I doubt that users, who want to understand if 'Zufalls-IDs' and 'Begegnungsaufzeichnungen' means the same, spontanously knew where to look it up (and do so). When I was reading the German section once again before writing this comment, I found that I overlooked the title of the German section before: 'Werden die gesammelten Zufalls-IDs beim Deinstallieren der App entfernt?' Following the title, the subject in this section handled 'Begegnungsaufzeichnungen' except inside the sixth paragraph. Together with the title, it's more clear, that 'Zufalls-IDs' also means 'Begegnungsaufzeichnungen'. However, I think the style can still be improved with minimum effort: So, my (pendatic) final proposal to improve both English and German texts is: I'm aware that you're not the creator of the original texts and the intentenion of this PR was a clarification in a different subject - but why not using the opportunity to improve style and comprehensibility?
Yes, you are right. But if we relied on the (sketchy) documentation by Google always, things may be improved with an extraordinary delay, if ever. I'm trusting @kbobrowski 's findings here corona-warn-app/cwa-app-android#1084 (comment) 100%, and if I remember correctly, there were additional user reports in this context that confirmed this fact. So a possible addition at the end of this section could be: English However, I respect the fact, that this addition is not in the scope of your PR and could be seperated. On the other hand, your PR is a nice opportunity to add these findings. Feel free to use/adapt above text, in case you agree.
When I'm submitting manuscripts to journals for review (or change requests on GH), I also don't plan any further changes to my work 😆 In best case there is a fast agreement of necessary (or possible) changes between submitter, referee and editor (on GH: product owner, here represented by @dsarkar ). So let's wait in modest patience for @dsarkar 's remarks. |
@vaubaehn I was attempting to make small changes to the article without questioning the base assumptions. I have marked up changes in the screen shots. I think it would be preferable to sign off first on the small changes and take your points into consideration as a separate issue. |
@MikeMcC399 |
Hi @thomasaugsten , when you find time would be nice if you could approve @MikeMcC399 's PR for technical correctness. Please ignore my comments in this place, they are not associated with the technical content. |
@vaubaehn The translation of "RPI" used by us should always be "Zufalls-IDs", but has not yet been changed in all FAQ entries. However, we can consider changing the heading to make it more clear what is meant by that. I would do this in my PR for #971 .
I'm not sure if we can just recommend a random app. Although it would work as a workaround of course. |
@MikeMcC399 @vaubaehn @heinezen Thanks! |
This PR implement text changes proposed in "FAQ: Effect of clear data on random ID storage" #1067 to FAQ articles:
(EN) Are the exposure logs/random IDs removed from my phone when I uninstall the app?
https://www.coronawarn.app/en/faq/#delete_random_ids
(DE) Werden die gesammelten Zufalls-IDs beim Deinstallieren der App entfernt?
https://www.coronawarn.app/de/faq/#delete_random_ids
Changes made
depending on Android version and implementation.
English (EN)
Are the exposure logs/random IDs removed from my phone when I uninstall the app?
https://www.coronawarn.app/en/faq/#delete_random_ids
German (DE)
Werden die gesammelten Zufalls-IDs beim Deinstallieren der App entfernt?
https://www.coronawarn.app/de/faq/#delete_random_ids
References
corona-warn-app/cwa-app-android#642 (comment) from on Oct 30, 2020 @thomasaugsten wrote:
Perhaps @thomasaugsten could review this PR for technical accuracy?
Internal Tracking ID: EXPOSUREAPP-5956