Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table tags in #interoperability_countries (DE) #3254

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Fix table tags in #interoperability_countries (DE) #3254

merged 2 commits into from
Nov 30, 2022

Conversation

MikeMcC399
Copy link
Contributor

This PR resolves issue #3253 "Tag errors in FAQ table #interoperability_countries (DE)" by making the following corrections in the https://www.coronawarn.app/de/faq/results/#interoperability_countries table:

From To
</tr><tr><tr><td>Norwegen </tr><tr><td>Norwegen
</tr><td>Polen </tr><tr><td>Polen
</tr><tr><tr><td>Slowenien </tr><tr><td>Slowenien
</tr><td>Spanien </tr><tr><td>Spanien

Verification

Due to the table being defined in one row of json it is very difficult to read. The git / GitHub diffs are also not much help. Visual inspection of the rendered table https://www.coronawarn.app/de/faq/results/#interoperability_countries and the validator https://validator.w3.org/ can help.

Local verification

Execute
npm run build

Open https://validator.w3.org/#validate_by_upload and choose local file public\de\faq\results\index.html in the base directory of cwa-website ensuring that no table errors are reported.

Remote verification

After merge of this PR open https://validator.w3.org/ and check https://www.coronawarn.app/de/faq/results/ ensuring that no table errors are reported.

@brianebeling brianebeling linked an issue Nov 30, 2022 that may be closed by this pull request
@brianebeling brianebeling added the bug Something isn't working label Nov 30, 2022
@brianebeling brianebeling self-assigned this Nov 30, 2022
@brianebeling brianebeling merged commit 19ff7e7 into corona-warn-app:master Nov 30, 2022
@MikeMcC399 MikeMcC399 deleted the fix/table-tags branch November 30, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag errors in FAQ table #interoperability_countries (DE)
2 participants