Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated encounter but green #343

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Updated encounter but green #343

merged 2 commits into from
Sep 1, 2020

Conversation

OlMue
Copy link
Contributor

@OlMue OlMue commented Sep 1, 2020

According to RKI feedback

OlMue added 2 commits September 1, 2020 11:12
@OlMue
Update faq_de.json
ba61a25 
Updated encounter_but_green according to RKI feedback
@OlMue
Update faq.json
4ab3750 
Updated encounter_but_green according to RKI feedback
@OlMue OlMue requested a review from SabineLoss September 1, 2020 09:19
@OlMue OlMue mentioned this pull request Sep 1, 2020
Merged
@OlMue OlMue merged commit 3eb2cd3 into master Sep 1, 2020
@OlMue OlMue deleted the OlMue-encounter_but_green branch September 1, 2020 10:48
@daimpi
Copy link
Contributor

daimpi commented Sep 1, 2020

@OlMue @SabineLoss
This changes seem to contradict #307 (comment)

Could you please clarify?

@OlMue
Copy link
Contributor Author

OlMue commented Sep 1, 2020

@daimpi Yes, I pointed this out in #319 (comment). I had to make this change first. I'm not involved in #319, so I'm not sure about the status but I assume that your suggestions will still be implemented. @MarlisFriedl @tkowark please check.

@daimpi
Copy link
Contributor

daimpi commented Sep 1, 2020

@OlMue this change goes in the exact opposite direction of what was discussed in #307

I was telling @svengabr about the problem with this change already last week on Slack and he agreed. And now this has just been merged nevertheless. This PR introduces potentially factually wrong information into the FAQ.

@OlMue
Copy link
Contributor Author

OlMue commented Sep 1, 2020

@daimpi I apologize, I wasn't aware of this.

@svengabr @mtb77: The request for the change this PR was forwarded to me by @janetback who was in contact with the RKI.

@daimpi
Copy link
Contributor

daimpi commented Sep 1, 2020

@OlMue ok, no problem, let's try to quickly get this sorted out then 🙂
If you want to join us on Slack btw here is the invitation link: https://join.slack.com/t/covidapps/shared_invite/zt-gmgl4l13-E4Xcn1ZfPFsPz6V_KjROCg (we're in the cwa channel)

@daimpi daimpi mentioned this pull request Sep 2, 2020
Closed
gittaca pushed a commit to gittaca/cwa-website that referenced this pull request Sep 4, 2020
@OlMue
Merge pull request corona-warn-app#343 from corona-warn-app/OlMue-enc…
8a2218f 
…ounter_but_green

Updated encounter but green
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SabineLoss SabineLoss SabineLoss approved these changes

@SebastianWolf-SAP SebastianWolf-SAP Awaiting requested review from SebastianWolf-SAP

@tkowark tkowark Awaiting requested review from tkowark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OlMue @daimpi @SabineLoss