Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployment of local API with public models is not possible without AWS creds #1588

Closed
RobertLucian opened this issue Nov 23, 2020 · 0 comments · Fixed by #1589
Closed

Deployment of local API with public models is not possible without AWS creds #1588

RobertLucian opened this issue Nov 23, 2020 · 0 comments · Fixed by #1589
Assignees
@RobertLucian
Labels
bug Something isn't working
Milestone
v0.23

Comments

@RobertLucian
Copy link
Member

Version

Since 0.22.

Description

When a local API is deployed that's using the live-reloading/multi-model caching feature and the specified model(s) is/are public, the API will stop abruptly if no AWS credentials have been configured for it (either via the local environment or by including the credentials in the .env file).

Suggested solution

If a model is public and there are no AWS credentials set, then the S3 client should be anonymous.
@RobertLucian RobertLucian added the bug Something isn't working label Nov 23, 2020
@RobertLucian RobertLucian self-assigned this Nov 23, 2020
@RobertLucian RobertLucian mentioned this issue Nov 23, 2020
Merged
2 tasks
@deliahu deliahu added this to the v0.23 milestone Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobertLucian RobertLucian

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.23
Development

Successfully merging a pull request may close this issue.

Allow local deployments of public models without requiring AWS creds cortexlabs/cortex
2 participants
@deliahu @RobertLucian