Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow local deployments of public models without requiring AWS creds #1589

Merged
merged 4 commits into from
Nov 23, 2020
Merged

Allow local deployments of public models without requiring AWS creds #1589

merged 4 commits into from
Nov 23, 2020

Conversation

RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Nov 23, 2020 •
edited
Loading

Fixes #1588.

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

deliahu
deliahu reviewed Nov 23, 2020
View reviewed changes
@RobertLucian RobertLucian merged commit 907b993 into master Nov 23, 2020
@RobertLucian RobertLucian deleted the fix/local-mmc branch November 23, 2020 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

@vishalbollu vishalbollu Awaiting requested review from vishalbollu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deployment of local API with public models is not possible without AWS creds
2 participants
@RobertLucian @deliahu