-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Use dskit/grpc* #4523
Merged
Merged
Chore: Use dskit/grpc* #4523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
force-pushed
the
chore/use-dskit-grpc
branch
7 times, most recently
from
October 8, 2021 09:11
f561007
to
742457a
Compare
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
force-pushed
the
chore/use-dskit-grpc
branch
from
October 8, 2021 09:24
742457a
to
b2c4c7c
Compare
pracucci
approved these changes
Oct 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
pstibrany
approved these changes
Oct 12, 2021
srijan55
pushed a commit
to srijan55/cortex
that referenced
this pull request
Nov 26, 2021
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: Manish Kumar Gupta <manishkg@microsoft.com>
aknuds1
added a commit
to aknuds1/cortex
that referenced
this pull request
Jan 12, 2022
This reverts commit 19f3802. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
added a commit
to aknuds1/cortex
that referenced
this pull request
Jan 13, 2022
This reverts commit 19f3802. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
pstibrany
pushed a commit
that referenced
this pull request
Jan 13, 2022
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: Alvin Lin <alvinlin@amazon.com>
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
) This reverts commit 19f3802. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: Alvin Lin <alvinlin@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Use gRPC packages from dskit instead of pkg/util/grpc*.
Which issue(s) this PR fixes:
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]