Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Use dskit/grpc* #4523

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Oct 8, 2021

What this PR does:
Use gRPC packages from dskit instead of pkg/util/grpc*.

Which issue(s) this PR fixes:

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@aknuds1 aknuds1 force-pushed the chore/use-dskit-grpc branch 7 times, most recently from f561007 to 742457a Compare October 8, 2021 09:11
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pstibrany pstibrany merged commit 19f3802 into cortexproject:master Oct 12, 2021
@aknuds1 aknuds1 deleted the chore/use-dskit-grpc branch October 13, 2021 07:58
srijan55 pushed a commit to srijan55/cortex that referenced this pull request Nov 26, 2021
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Manish Kumar Gupta <manishkg@microsoft.com>
aknuds1 added a commit to aknuds1/cortex that referenced this pull request Jan 12, 2022
This reverts commit 19f3802.

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1 added a commit to aknuds1/cortex that referenced this pull request Jan 13, 2022
This reverts commit 19f3802.

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
pstibrany pushed a commit that referenced this pull request Jan 13, 2022
This reverts commit 19f3802.

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
alvinlin123 pushed a commit to ac1214/cortex that referenced this pull request Jan 14, 2022
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Alvin Lin <alvinlin@amazon.com>
alvinlin123 pushed a commit to ac1214/cortex that referenced this pull request Jan 14, 2022
)

This reverts commit 19f3802.

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Alvin Lin <alvinlin@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants