Reintroduce grpc* packages #4612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
reviewed
Jan 12, 2022
| @@ -0,0 +1,87 @@ | |||
| package tls | |||
There was a problem hiding this comment.
You should replace imports of "github.com/grafana/dskit/crypto/tls" with this one.
There was a problem hiding this comment.
@pracucci dskit/crypto/tls is actually only imported within dskit itself though, within the dskit/kv package. They will go away when the kv package is reintroduced into Cortex :)
pracucci
approved these changes
Jan 12, 2022
|
This also needs to be rebased now :-( |
This reverts commit 19f3802. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
force-pushed
the
chore/reintroduce-grpc
branch
from
9e0f8dc
to
5447547
Compare
@pstibrany done. |
|
Thank you. |
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
) This reverts commit 19f3802. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: Alvin Lin <alvinlin@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Revert usage of grafana/dskit/grpc* packages. I've copied the current corresponding code from dskit.
Which issue(s) this PR fixes:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]