-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test:cover
results in "No coverage information was collected, exit without writing coverage information"
#245
Comments
Can you try on the native Mac terminal? Runs fine for me there. |
Same issue here. When running on the native Mac terminal it gives no coverage information. However if I change the path to _mocha from Running the same on a windows machine (through VSTS, Visual Studio Team Service builds), it gives no coverage information either with the So it seems the issue is not with the path to _mocha? |
Shouldn't node_modules, have a |
Made a mistake, it's The |
Right, does switching it to |
Negative. It doesn't break anything either, but still no coverage output. |
test:cover
resulting in "No coverage information was collected, exit without writing coverage information"test:cover
results in "No coverage information was collected, exit without writing coverage information"
I assume you have unit tests defined? Sorry for the obvious question. |
In my case, yes, I do have unit tests defined. |
Just did a clone of this project so I could check if it was related to my own project, but still getting the same result:
Really wondering what's the difference between
|
Just chiming in to say I am also experiencing this problem. Same version of Node/NPM as OP, running on Windows 10. I have just tested on a freshly pulled If anyone has an old install which is working could you paste a snapshot of your installed |
It seems it broke with istanbul 0.4.5 I had similar problem on windows as you guys describe, and installing (--save-dev) istanbul 0.4.4 worked for me. |
Nice one @ArcanisCz, that works a treat! |
Great find @ArcanisCz ! Hrmm, now question is, how can I fix this for everyone? Istanbul is not a direct dependency since Isparta merely uses it behind the scenes. So I believe we have to wait until either Isparta changes their reference or Istanbul fixes the bug. And in other news, I'm strongly considering moving the project to Jest since it includes this built in and is generally now considered the best option for React dev. |
@coryhouse I am very interested in giving jest a try. Let me know if you want me to take a first pass on this? |
Setting the istanbul dev-dependency to 0.4.4 explicitly fixes the issue. @coryhouse: this might be a temporary fix for users of this project. I'm also interested in seeing jest integrated. |
@kwelch I'd love to see a PR on Jest! 👍 I'm eager to try it but have read enough to know it sounds like a slam dunk now. |
+1 for you guys helping solve the issue and +2 for Jest. Possible Pluralsight vid on Jest in the future @coryhouse ? You talked about it quite a bit in the redux one but at that time it was still wonky 🗡 |
I am not able to see even the absent output. When I run
|
I've been running in to the same ELIFECYCLE error as mherodev, is there any fix for this? |
I am using Jest in my new course @oshalygin. I've lost patience with trying to keep code coverage working with Mocha. It just seems to be a house of cards. I'd like to move Slingshot to Jest since it has a much simpler config story, snapshot tests, and code coverage built in. I'd welcome a PR from anyone willing. |
@kwelch, I guess that means you'll be looking at merging your Jest PR? |
I was able to get coverage working in my own fork by making the istanbul version change, targeting I'll see if I can get it working within this repository later tonight. Sorry for the wait. If the migration to Jest isn't huge, I'd love to make it myself. |
@nickytonline I am looking to carve out time this week to wrapping that up. The tests run successfully, but output is still excessive and I have not touched coverage. The branch is directly on this repo so PRs/commits to that branch are welcome with anything that will move the needle forward. |
@kwelch cool beans. I have some free time this weekend, so I'll take a peek at the branch then. |
I have a fix for the test coverage, but I can't seem to push to this repository.
I made a fresh SSH key, pulled the repository, and it seems fine... outside of not being able to push, e.g.
|
Great to hear Michael! You can't commit directly - but you can submit a
pull request.
…On Wed, Jan 25, 2017 at 6:10 AM, Michael Herold ***@***.***> wrote:
I have a fix for the test coverage, but I can't seem to push to this
repository.
mherold-mac:react-slingshot mherold$ git push
ERROR: Permission to coryhouse/react-slingshot.git denied to mherodev.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
I made a fresh SSH key, pulled the repository, and it seems fine...
outside of not being able to push, e.g.
Hi mherodev! You've successfully authenticated, but GitHub does not
provide shell access.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#245 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABnFpQzAOjzggs296CpRZ8u7zp0VpIRqks5rVzubgaJpZM4Jsk2J>
.
--
Cory House
bitnative.com
<http://www.bitnative.com>
Pluralsight Courses <http://www.pluralsight.com/author/cory-house>
[image: https://mvp.microsoft.com/en-us/mvp/Cory%20House-5000840]
<https://mvp.microsoft.com/en-us/mvp/Cory%20House-5000840>
|
@mherodev There is a good egghead video by @kentcdodds if this is your first PR. 👍 |
I've committed thousands of PRs professionally, but this would likely be my first open source contribution 💃 For some reason, I cannot submit a new branch to this repository.
I'll see if that egghead video has any insight. In the mean time, should I not be using the Also, odd that it says |
You'll need to fork the repo. You'll learn about that in the course :) |
Oh good, I'm glad I was doing it wrong. whew! Edit: And hey Kent! Thanks for the video 💯 |
Got 'em: #358 Thanks for your help @kentcdodds, and @kwelch for the link. |
Node version:
6.3.0
npm version:
3.10.3
Operating system:
OSX
Command line used:
zsh
Steps to reproduce:
npm run test:cover
The text was updated successfully, but these errors were encountered: