Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default types from AminoTypes #1081

Merged
merged 17 commits into from
Mar 10, 2022
Merged

Remove default types from AminoTypes #1081

merged 17 commits into from
Mar 10, 2022

Conversation

msteiner96
Copy link
Member

Resolves #1079

@msteiner96 msteiner96 requested a review from webmaster128 March 9, 2022 14:28
@msteiner96 msteiner96 marked this pull request as ready for review March 9, 2022 14:28
@msteiner96 msteiner96 requested a review from webmaster128 March 9, 2022 15:31
webmaster128
webmaster128 reviewed Mar 10, 2022
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, nice. Just a bit of formatting, fixing the CI and, moving two types and a CHANGELOG entry

packages/stargate/src/aminotypes.ts Outdated Show resolved Hide resolved
packages/stargate/src/modules/bank/aminomessages.spec.ts Outdated Show resolved Hide resolved
packages/stargate/src/modules/distribution/aminomessages.spec.ts Outdated Show resolved Hide resolved
packages/stargate/src/modules/gov/aminomessages.spec.ts Outdated Show resolved Hide resolved
packages/stargate/src/modules/ibc/aminomessages.spec.ts Outdated Show resolved Hide resolved
packages/stargate/src/modules/staking/aminomessages.spec.ts Outdated Show resolved Hide resolved
msteiner96 and others added 9 commits March 10, 2022 08:52
@msteiner96 @webmaster128
Update packages/stargate/src/modules/bank/aminomessages.spec.ts
a01143c 
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
@msteiner96 @webmaster128
Update packages/stargate/src/modules/ibc/aminomessages.spec.ts
c66540d 
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
@msteiner96 @webmaster128
Update packages/stargate/src/modules/staking/aminomessages.spec.ts
d4e23e8 
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
@msteiner96 @webmaster128
Update packages/stargate/src/modules/gov/aminomessages.spec.ts
5f2b209 
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
@msteiner96 @webmaster128
Update packages/stargate/src/modules/distribution/aminomessages.spec.ts
6da6b65 
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
@msteiner96
Fix CI Errors
7960209
@msteiner96
Merge branch 'remove-default-aminotypes' of github.com:cosmos/cosmjs …
4eab461 
…into remove-default-aminotypes
@msteiner96
Moved AminoConverts back to aminotypes.ts
d8d1e7c
@msteiner96
Added Changes to Changelog.md
164881e
@msteiner96 msteiner96 requested a review from webmaster128 March 10, 2022 10:43
webmaster128
webmaster128 approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@webmaster128 webmaster128 merged commit 0fe5c0c into main Mar 10, 2022
@webmaster128 webmaster128 deleted the remove-default-aminotypes branch March 10, 2022 17:02
@webmaster128 webmaster128 mentioned this pull request Mar 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove default types from AminoTypes
2 participants
@msteiner96 @webmaster128