.js extension imports from @noble/hashes #1821
Merged
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, thanks. But could you check |
webmaster128
added a commit
that referenced
this pull request
Oct 8, 2025
and elaborate on affected users as pointed out in #1821
webmaster128
added a commit
that referenced
this pull request
Oct 8, 2025
and elaborate on affected users as pointed out in #1821
extensionless imports are deprecated in 1.8 and removed in 2.0. Missed these two in the earlier deprecation warnings fixes cosmos#1767.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for #1816
cosmjs/CHANGELOG.md
Line 18 in ed7774b
This line in the 0.36.1 changelog isn't exactly true (also, there's a release on npm but no 0.36.1 in github releases?). It was only true of versions < 1.8.0.
Extensionless imports are removed in 2.0, so they were marked deprecated in 1.8.0 and
.jsexports were added for a smooth v2 upgrade.https://github.com/paulmillr/noble-hashes/releases/tag/1.8.0
https://github.com/paulmillr/noble-hashes/releases/tag/2.0.0
Undoes #1817
Fix on #1767 7f2f8a8 (this introduced a bug in codebases who hadn't updated to 1.8.0+ on their own already. All tests continued to pass because 1.8.0 is already in the
yarn.lockfile ever since the big update from 1.0 to 1.8 in #1672)