Skip to content

.js extension imports from @noble/hashes #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2025
Merged

.js extension imports from @noble/hashes #1821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
954188e
crypto: depend on @noble/hashes >= 1.8.0
dynst Oct 8, 2025
ed84b1f
revert "Remove .js extensions from @noble/hashes imports"
dynst Oct 8, 2025
5987237
always import @noble/hashes with .js extension
dynst Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/crypto/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"@cosmjs/utils": "workspace:^",
"@noble/ciphers": "^1.3.0",
"@noble/curves": "^1.9.2",
"@noble/hashes": "^1",
"@noble/hashes": "^1.8.0",
"hash-wasm": "^4.12.0"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/crypto/src/keccak.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { keccak_256 } from "@noble/hashes/sha3";
import { keccak_256 } from "@noble/hashes/sha3.js";

import { HashFunction } from "./hash";
import { toRealUint8Array } from "./utils";
Expand Down
4 changes: 2 additions & 2 deletions packages/crypto/src/pbkdf2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { assert } from "@cosmjs/utils";
import { pbkdf2Async as noblePbkdf2Async } from "@noble/hashes/pbkdf2";
import { sha512 as nobleSha512 } from "@noble/hashes/sha2";
import { pbkdf2Async as noblePbkdf2Async } from "@noble/hashes/pbkdf2.js";
import { sha512 as nobleSha512 } from "@noble/hashes/sha2.js";

/**
* Returns the SubtleCrypto API for this environment if present.
Expand Down
2 changes: 1 addition & 1 deletion packages/crypto/src/ripemd.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ripemd160 as nobleRipemd160 } from "@noble/hashes/legacy";
import { ripemd160 as nobleRipemd160 } from "@noble/hashes/legacy.js";

import { HashFunction } from "./hash";
import { toRealUint8Array } from "./utils";
Expand Down
2 changes: 1 addition & 1 deletion packages/crypto/src/sha.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { sha256 as nobleSha256, sha512 as nobleSha512 } from "@noble/hashes/sha2";
import { sha256 as nobleSha256, sha512 as nobleSha512 } from "@noble/hashes/sha2.js";

import { HashFunction } from "./hash";
import { toRealUint8Array } from "./utils";
Expand Down
4 changes: 2 additions & 2 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ __metadata:
"@istanbuljs/nyc-config-typescript": "npm:^1.0.1"
"@noble/ciphers": "npm:^1.3.0"
"@noble/curves": "npm:^1.9.2"
"@noble/hashes": "npm:^1"
"@noble/hashes": "npm:^1.8.0"
"@types/jasmine": "npm:^4"
"@types/karma-firefox-launcher": "npm:^2"
"@types/karma-jasmine": "npm:^4"
Expand Down Expand Up @@ -1185,7 +1185,7 @@ __metadata:
languageName: node
linkType: hard

"@noble/hashes@npm:1.8.0, @noble/hashes@npm:^1, @noble/hashes@npm:^1.7.1":
"@noble/hashes@npm:1.8.0, @noble/hashes@npm:^1.7.1, @noble/hashes@npm:^1.8.0":
version: 1.8.0
resolution: "@noble/hashes@npm:1.8.0"
checksum: 10c0/06a0b52c81a6fa7f04d67762e08b2c476a00285858150caeaaff4037356dd5e119f45b2a530f638b77a5eeca013168ec1b655db41bae3236cb2e9d511484fc77
Expand Down
Loading