Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Message Types Status in GlobalParams #1161

Closed
gamarin2 opened this issue Jun 7, 2018 · 4 comments
Closed

Store Message Types Status in GlobalParams #1161

gamarin2 opened this issue Jun 7, 2018 · 4 comments
Assignees
Labels

Comments

@gamarin2
Copy link
Contributor

gamarin2 commented Jun 7, 2018

Related to #1159

As per discussion with @sunnya97, we could store Msg.Type() status in GlobalParams. Status would be a boolean, "true" for activated, "false" for deactivated.

Key: Msg.Type() -> Value: Status (bool)

Msg types could be activated/deactivated with ParameterChangeProposals. We'd just need to add a check in runTx() (or elsewhere). After we decode the TX and get the msg type, we just check the status of this msg type in GlobalParams. Then we go further only if msg type is activated.

This would help a lot to implement:

  • Circuit breaker
  • Activation of transfer during launch rollout
@mossid
Copy link
Contributor

mossid commented Jun 20, 2018

Would antehandler instead of runTx also work for checking the validity of the type?

@sunnya97
Copy link
Member

@cwgoes Why was this closed?

@cwgoes
Copy link
Contributor

cwgoes commented Jul 16, 2018

Unclear, PR #1265 was marked as closing this issue but I don't think it does.

@jackzampolin
Copy link
Member

I think we abandoned this direction. Please reopen if I'm wrong.

chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this issue Mar 1, 2024
)

Bumps [vuepress-theme-cosmos](https://github.com/cosmos/vuepress-theme-cosmos) from 1.0.182 to 1.0.183.
- [Release notes](https://github.com/cosmos/vuepress-theme-cosmos/releases)
- [Commits](https://github.com/cosmos/vuepress-theme-cosmos/commits)

---
updated-dependencies:
- dependency-name: vuepress-theme-cosmos
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants