-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global Paramstore #1265
Global Paramstore #1265
Conversation
Hmm, I wonder if it might be better to have a few explicit types instead of using reflection. |
Just linking these two issues that are relevant to this PR @mossid @sunnya97 :
|
Codecov Report
@@ Coverage Diff @@
## master #1265 +/- ##
==========================================
+ Coverage 63.78% 65.75% +1.96%
==========================================
Files 122 120 -2
Lines 6763 6924 +161
==========================================
+ Hits 4314 4553 +239
+ Misses 2204 2117 -87
- Partials 245 254 +9 |
@cwgoes What do you mean by a few explicit types? |
2a4c76a
to
ac1ed5a
Compare
94bb76c
to
b5a6695
Compare
Suspended until #1119 is merged |
b5a6695
to
9e322bf
Compare
9e322bf
to
0967763
Compare
fc421d9
to
ba13dcb
Compare
ba13dcb
to
1bd3318
Compare
1bd3318
to
f956c9d
Compare
Revert all changes those depends on #1119, ready for review |
#1119 is merged. Maybe we can merge it after applying it to stake module. |
82f41e0
to
1f35556
Compare
1f35556
to
abedd24
Compare
abedd24
to
905ef51
Compare
905ef51
to
340804e
Compare
in progress in progress stake and slashing now params fix gaia fix gaia again add msg type deactivation delete local error in progress revert actual application in baseapp/gaia/stake add test, fix apps fix MinSignedPerWindow, pass lint fix gaia fix keeper_test fit with multiple msgs fix apply requests pass lint really the last fix fix dependency fix keeper_test fix lint
@mossid Did you want to update this with the stake module parameters prior to merge? |
@cwgoes I think we can merge it for now, will make another PR for stake params. |
// TODO Governance parameter? | ||
MinSignedPerWindow = SignedBlocksWindow / 2 | ||
// TODO Temporarily set to 100 blocks for testnets | ||
defaultSignedBlocksWindow int64 = 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be 40000
// TODO Temporarily set to five minutes for testnets | ||
DowntimeUnbondDuration int64 = 60 * 5 | ||
// TODO Temporarily set to 10 minutes for testnets | ||
defaultDowntimeUnbondDuration int64 = 60 * 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be 5 minutes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ACK, would like @rigelrozanski's opinion before merge.
in progress in progress stake and slashing now params fix gaia fix gaia again add msg type deactivation delete local error in progress revert actual application in baseapp/gaia/stake add test, fix apps fix MinSignedPerWindow, pass lint fix gaia fix keeper_test fit with multiple msgs fix apply requests pass lint really the last fix fix dependency fix keeper_test fix lint
d962dd9
to
fbf71b0
Compare
Needs to be reopened against |
Master was merged back to develop. |
@mossid
I think they are much helpful in query a set of keys. |
Closes: #1159
Closes: #1161