-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate usage of sdk.Math to cosmossdk.io/math #14405
Labels
Comments
tac0turtle
added
good first issue
T:tech debt
Tech debt that should be cleaned up
labels
Dec 23, 2022
tac0turtle
changed the title
migrate sdk.Math to cosmossdk.io/math
migrate usage of sdk.Math to cosmossdk.io/math
Dec 26, 2022
19 tasks
Note, you cannot remove func (ip IntProto) String() string {
return ip.Int.String()
}
func (dp DecProto) String() string {
return dp.Dec.String()
} |
true, at least its less code to maintain. Is there anyway to remove those? |
19 tasks
This was referenced Mar 30, 2023
19 tasks
mergify bot
pushed a commit
that referenced
this issue
Apr 13, 2023
## Description Closes part of: #14405 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... * [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title * [ ] added `!` to the type prefix if API or client breaking change * [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) * [ ] provided a link to the relevant issue or specification * [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules) * [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) * [ ] added a changelog entry to `CHANGELOG.md` * [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) * [ ] updated the relevant documentation or specification * [ ] reviewed "Files changed" and left comments if necessary * [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... * [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title * [ ] confirmed `!` in the type prefix if API or client breaking change * [ ] confirmed all author checklist items have been addressed * [ ] reviewed state machine logic * [ ] reviewed API design and naming * [ ] reviewed documentation is accurate * [ ] reviewed tests and test coverage * [ ] manually tested (if applicable)
19 tasks
19 tasks
19 tasks
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
migrate the usage of sdk.Math throughout the repo to cosmossdk.io/math.
types/math.go is an alias to cosmossdk.io/math, we should migrate all calls to types/math.go to the go mod and remove the alias in types.
Work
The text was updated successfully, but these errors were encountered: