refactor(misc): remove aliases from types/math.go #16320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team,
aaronc and
testinginprod
and removed request for
a team
github-actions
bot
added
C:CLI
C:Simulations
C:x/auth
C:x/authz
C:x/bank
C:x/crisis
C:x/distribution
tac0turtle
reviewed
May 28, 2023
| @@ -1,15 +1,15 @@ | |||
| package gov_test | |||
|
|
|||
| import ( | |||
| "github.com/stretchr/testify/require" | |||
tac0turtle
reviewed
May 28, 2023
julienrbrt
reviewed
May 28, 2023
| @@ -240,6 +240,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
| * this finalizes the gov collections migration | |||
| * Removed: keeper `InsertActiveProposalsQueue`, `RemoveActiveProposalsQueue`, `InsertInactiveProposalsQueue`, `RemoveInactiveProposalsQueue`, `IterateInactiveProposalsQueue`, `IterateActiveProposalsQueue`, `ActiveProposalsQueueIterator`, `InactiveProposalsQueueIterator` | |||
| * Remove: types all the key related functions | |||
| * (types/math) [#16320](https://github.com/cosmos/cosmos-sdk/pull/16320) Remove aliases from `types/math.go`. | |||
There was a problem hiding this comment.
Not needed, there is one entry already in the changelog.
Suggested change
| * (types/math) [#16320](https://github.com/cosmos/cosmos-sdk/pull/16320) Remove aliases from `types/math.go`. |
There was a problem hiding this comment.
We can add this PR number to the existing entry with comma separated?
There was a problem hiding this comment.
is a draft, will close issue
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
As part of the types audit (#16475 (comment)) I am going to push that to the finish line for avoiding inconsistencies in v0.50. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #14405
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change