Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator power not correctly updated when decreased but not unbonded #1567

Closed
cwgoes opened this issue Jul 6, 2018 · 2 comments
Closed

Validator power not correctly updated when decreased but not unbonded #1567

cwgoes opened this issue Jul 6, 2018 · 2 comments
Assignees
@cwgoes
Labels
C:x/staking T:Bug

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Jul 6, 2018

Ref #1457 (comment). When a validator's power is decreased - through a partial unbonding, for example - but not decreased enough to remove that validator from the bonded set, the update isn't sent back correctly to Tendermint.

Testcase to replicate in #1566.
@cwgoes cwgoes mentioned this issue Jul 6, 2018
Closed
@rigelrozanski
Copy link
Contributor

bizarre - thanks for writing the testcase

@cwgoes cwgoes mentioned this issue Jul 6, 2018
Closed
16 tasks
@cwgoes cwgoes added the T:Bug label Jul 6, 2018
@ebuchman ebuchman mentioned this issue Jul 6, 2018
Closed
@cwgoes
Copy link
Contributor Author

cwgoes commented Jul 6, 2018

Closed by #1566.

@cwgoes cwgoes closed this as completed Jul 6, 2018
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this issue Mar 1, 2024
@yaruwangway @glnro @okwme
add bypass-min-fee (cosmos#1539)
3b1758f 
* add bypass-min-fee

* fix: lint

* chore: change comment position

* add bypass min fee test

* fix: lint

* Update ante/fee.go

Co-authored-by: lg <8335464+glnro@users.noreply.github.com>

* Update ante/fee.go

Co-authored-by: lg <8335464+glnro@users.noreply.github.com>

* refactor: FeeWithBypassDecorator -> BypassMinFeeDecorator

* create fallback default bypass min fee messages (cosmos#1567)

* Update app/app.go

Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com>

Co-authored-by: lg <8335464+glnro@users.noreply.github.com>
Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwgoes cwgoes

Labels
C:x/staking T:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ebuchman @rigelrozanski @cwgoes