Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makefile: Remove rm -rf vendors from make get_vendor_deps #1715

Closed
ValarDragon opened this issue Jul 17, 2018 · 0 comments
Closed

makefile: Remove rm -rf vendors from make get_vendor_deps #1715

ValarDragon opened this issue Jul 17, 2018 · 0 comments
Labels
T: CI

Comments

@ValarDragon
Copy link
Contributor

This step is no longer necessary now that we pin to revisions, and because if we did pin to a branch, we now ensure the gopkg.lock is in sync with the the latest version of any branch. (This happens in the linting step)

Made this an issue instead of a PR, just to make sure there isn't something I'm missing about why we rm -rf vendors.
@ValarDragon ValarDragon changed the title Remove rm -rf vendors from make get_vendor_deps makefile: Remove rm -rf vendors from make get_vendor_deps Jul 17, 2018
ValarDragon added a commit that referenced this issue Jul 18, 2018
@ValarDragon
tools: remove rm -rf vendor/ from make get_vendor_deps
bdbfc04 
We now ensure that the Gopkg.lock is correct, and that the toml
doesn't depend on any branches, so this is no longer necessary.

Closes #1715
@ValarDragon ValarDragon mentioned this issue Jul 18, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T: CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ValarDragon