Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: remove rm -rf vendor/ from make get_vendor_deps #1731

Merged
merged 1 commit into from
Jul 18, 2018

Conversation

ValarDragon
Copy link
Contributor

@ValarDragon ValarDragon commented Jul 18, 2018

We now ensure that the Gopkg.lock is correct, and that the toml
doesn't depend on any branches, so this is no longer necessary.

Closes #1715

  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Updated CHANGELOG.md
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

We now ensure that the Gopkg.lock is correct, and that the toml
doesn't depend on any branches, so this is no longer necessary.

Closes #1715
@codecov
Copy link

codecov bot commented Jul 18, 2018

Codecov Report

Merging #1731 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1731   +/-   ##
========================================
  Coverage    62.35%   62.35%           
========================================
  Files          120      120           
  Lines         7119     7119           
========================================
  Hits          4439     4439           
  Misses        2429     2429           
  Partials       251      251

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, excellent

Prior to launch we need to go over our dependency security, and possibly audit a few then pin exact versions.

@cwgoes cwgoes merged commit 2c81f49 into develop Jul 18, 2018
@cwgoes cwgoes deleted the dev/remove_rm_rf_from_make branch July 18, 2018 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants