-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Middleware instead of Decorator for nomenclature #317
Comments
Agreed, but the concept of decorators has now been removed altogether |
ParthDesai
pushed a commit
to ChorusOne/cosmos-sdk
that referenced
this issue
Apr 19, 2021
* Add v0.3.1 to archives * git LFS and add reference to previous versions
rootulp
referenced
this issue
in rootulp/cosmos-sdk
May 17, 2023
…tion (#317) * feat: allow for the default consensus params to be set by the application * chore: add test * fix: spelling Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com> --------- Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
MSalopek
pushed a commit
to MSalopek/cosmos-sdk
that referenced
this issue
Oct 8, 2023
…tion (cosmos#317) (cosmos#345) * feat: allow for the default consensus params to be set by the application * chore: add test * fix: spelling --------- Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently we are using Decorator for wrapped functions that take in a context, multistore and then invoke next. The usage of the term Decorator required some developer education on Python and the idea of wrapping functions to produce other functions.
In the meeting @jaekwon raised the familiarity to Node.js' Express framework, but in Express they call them Middleware and in Express, Middleware take in a (request, response, next Handler) where the usage is similar to what Decorate does.
This is a suggestion for us to change names from Decorator to Middleware.
I believe Middleware is more familiar to people and easier to look up as Go's networking libraries also talk about Middleware and it's a popular concept in web services development too.
The text was updated successfully, but these errors were encountered: