-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evan/re add default consensus params #17617
Closed
evan-forbes
wants to merge
366
commits into
cosmos:main
from
celestiaorg:evan/re-add-default-consensus-params
Closed
Evan/re add default consensus params #17617
evan-forbes
wants to merge
366
commits into
cosmos:main
from
celestiaorg:evan/re-add-default-consensus-params
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… balance for a given denom (backport cosmos#12674) (cosmos#12744) * feat: Add convenience method for constructing key to access account's balance for a given denom (cosmos#12674) This PR adds a convenience method for constructing the key necessary to query for the account's balance of a given denom. I ran into this issue since we are using ABCI query now to perform balance requests because we are also requesting merkle proofs for the returned balance [here](https://github.com/celestiaorg/celestia-node/pull/911/files#diff-0ee31f5a7bd88e9f758e6bebdf3ee36365519e55a451098d9638c39afe5eac42R144). It would be nice to have a definitive convenience method for constructing the key. [Ref.](github.com/celestiaorg/celestia-node/pull/911) (cherry picked from commit a1777a8) * updates changelog Co-authored-by: rene <41963722+renaynay@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
…ges (backport cosmos#12615) (cosmos#12792) * feat: Add GetParamSetIfExists to prevent panic on breaking param changes (cosmos#12615) * imp(params): Add GetParamSetIfExists to prevent panic on breaking param changes * changelog * test Co-authored-by: Marko <marbar3778@yahoo.com> (cherry picked from commit 2932e11) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Marko <marbar3778@yahoo.com>
…lease chore: create a v0.46.0 release branch with celestia specific changes
* adds orchestrator address to validator initialization in staking module * fix msg edit validator * todo * todo
…r struct (#133) * first pass on tests fixes * fixes the rest of unit tests * remove unnecessary comments * uses default eth address when starting sim network * cosmetics * comments failing test * comments failing test * uncomments test and fixes it from commit 434b308 * remove wrong testnet initialization
* first pass on tests fixes * fixes the rest of unit tests * remove unnecessary comments * uses default eth address when starting sim network * cosmetics * comments failing test * comments failing test * adds orchestrator/ethereum address checks for validators when creating and editing * uses correct error codes for eth/orch address errors * uncomments test and fixes it from commit 434b308 * adds zero eth address check when creating/updating validator * attempts to fix duplicate eth address in sim network * revert squashed changes * uses unwrapped context for msg_server orch/eth validation * increase DefaultGenTxGas to accomodate new qgb validator changes * scaffolds an ethereum address from orchestrator address in staking simulation to have a deterministic way of creating it * fix eth address creation from orch address in operations * increase DefaultGenTxGas * increase DefaultGenTxGas * simpler way of creating an eth address from orch address in operations
* first pass on tests fixes * fixes the rest of unit tests * remove unnecessary comments * uses default eth address when starting sim network * cosmetics * comments failing test * comments failing test * adds orchestrator/ethereum address checks for validators when creating and editing * uses correct error codes for eth/orch address errors * uncomments test and fixes it from commit 434b308 * updates tests to be able to set orch/eth address when creating validators * adds zero eth address check when creating/updating validator * attempts to fix duplicate eth address in sim network * adds validator check tests * revert squashed changes * uses unwrapped context for msg_server orch/eth validation * increase DefaultGenTxGas to accomodate new qgb validator changes * scaffolds an ethereum address from orchestrator address in staking simulation to have a deterministic way of creating it * fix eth address creation from orch address in operations * increase DefaultGenTxGas * increase DefaultGenTxGas * remove unnecessary eth address
* remove EthAddress and use geth address * adding checks on ethereum address when creating it * fix ethereum address init when creating validator * fix edit validator
go mod tidy go mod tidy remove unnecessary change remove unnecessary else branch fix gentx test update staking.pb.go fix staking cli tests fixing tests: first pass proto-gen
…ial-probably chore!: Upgrade QGB branch to v0.46.0
(cherry picked from commit fe89212) Co-authored-by: Ari Rubinstein <arirubinstein@users.noreply.github.com>
…osmos#12840) (cherry picked from commit cfed17e) Co-authored-by: lg <8335464+glnro@users.noreply.github.com>
* chore: bump math package * changelog
github-actions
bot
added
C:x/staking
C:CLI
C:x/gov
C:x/slashing
C:Keys
Keybase, KMS and HSMs
C:x/distribution
distribution module related
C:x/mint
C:Simulations
C:Store
C:x/bank
C:x/params
C:x/crisis
C:x/auth
C:x/evidence
C:x/upgrade
C:x/feegrant
C:x/genutil
genutil module issues
C:x/authz
C:x/group
C:x/nft
C:orm
Type: Build
Type: ADR
Type: CI
C:container
labels
Sep 4, 2023
omg wrong base |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C:CLI
C:Keys
Keybase, KMS and HSMs
C:orm
C:Simulations
C:Store
C:x/auth
C:x/authz
C:x/bank
C:x/crisis
C:x/distribution
distribution module related
C:x/evidence
C:x/feegrant
C:x/genutil
genutil module issues
C:x/gov
C:x/group
C:x/mint
C:x/nft
C:x/params
C:x/slashing
C:x/staking
C:x/upgrade
Type: ADR
Type: Build
Type: CI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
we [afaiu] accidently removed our ability to change the default consesus parameters in #339
this PR re-cherry-picks #317 to fix