Unused and missing tags on MsgCreateValidator

[fedekunze]

Summary of Bug

MsgCreateValidator currently has tags that imho are not necessary/useful: moniker and identity (this one also doesn't contain any value if the user doesn't provide any identity).

Besides, it's missing a delegator tag entry. Currently clients have to modify the bech32 prefix of a delegator to check for this type of transaction though the GET /txs endpoint.

Steps to Reproduce

{
  "height": "193281",
  "txhash": "DB8F2DAFD4791337E57921DB2D7D7838E14492323FECB391BB39D51239BA3FBF",
  "log": "[{\"msg_index\":\"0\",\"success\":true,\"log\":\"\"}]",
  "gas_wanted": "101587",
  "gas_used": "101577",
  "tags": [
    {
      "key": "action",
      "value": "create_validator"
    },
    {
      "key": "destination-validator",
      "value": "cosmosvaloper1qecshyc40kshszkwrtscgmsdd8tz3n4hrj9yf2"
    },
    {
      "key": "moniker",
      "value": "propelmind"
    },
    {
      "key": "identity"
    }
  ],
  "tx": {
    "type": "auth/StdTx",
    "value": {
      "msg": [
        {
          "type": "cosmos-sdk/MsgCreateValidator",
          "value": {
            "description": {
              "moniker": "propelmind",
              "identity": "",
              "website": "",
              "details": ""
            },
            "commission": {
              "rate": "0.100000000000000000",
              "max_rate": "0.200000000000000000",
              "max_change_rate": "0.010000000000000000"
            },
            "min_self_delegation": "1",
            "delegator_address": "cosmos1qecshyc40kshszkwrtscgmsdd8tz3n4hxx339e",
            "validator_address": "cosmosvaloper1qecshyc40kshszkwrtscgmsdd8tz3n4hrj9yf2",
            "pubkey": "cosmosvalconspub1zcjduepqjja8zg8ccvdd5rx50ad79faaaucq5vr98pr7eawnslqrscelwhaszhaq83",
            "value": {
              "denom": "muon",
              "amount": "1000000"
            }
          }
        }
      ],
      "fee": {
        "amount": null,
        "gas": "101587"
      },
      "signatures": [
        {
          "pub_key": {
            "type": "tendermint/PubKeySecp256k1",
            "value": "ArnKulECjCWw1IZNAj7UmGEeenfgTOPUmhGHnDwynYa3"
          },
          "signature": "t76SdT5xfg/ZzRopzrMPWINdGu3nOZnAql0ZuS5ANWdj+BI+dYJHMSt7hLID0eLm4VxNdhrR9VZ/L9yuFv2IGg=="
        }
      ],
      "memo": ""
    }
  }
}

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned