fix and cleanup action tags

[fedekunze]

Fixes #3966
Closes #3793

• Targeted PR against correct branch (see CONTRIBUTING.md)

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

• Wrote tests

• Updated relevant documentation (docs/)

• Added a relevant changelog entry: sdkch add [section] [stanza] [message]

• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (develop@055d219). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             develop    #4045   +/-   ##
==========================================
  Coverage           ?   59.78%           
==========================================
  Files              ?      212           
  Lines              ?    15154           
  Branches           ?        0           
==========================================
  Hits               ?     9060           
  Misses             ?     5450           
  Partials           ?      644

[alessio]

Looks good to me, though I'm not sure this is sufficient to close #3966
I'd wait for an extra approval then.

[fedekunze]

I need to make a few changes based on our endblocker tags discussions with @alessio

[alexanderbez]

Does this PR fully address #3966?

x/gov/tags/tags.go:13:  Action            = sdk.TagAction
x/slashing/tags/tags.go:9:      Action    = sdk.TagAction
x/staking/alias.go:180: TagAction       = tags.Action
x/staking/handler.go:63:                        tags.Action, ActionCompleteUnbonding,
x/staking/handler.go:79:                        tags.Action, tags.ActionCompleteRedelegation,
x/staking/tags/tags.go:12:      Action       = sdk.TagAction

[fedekunze]

Does this PR fully address #3966?

these are for the staking EndBlocker do we need to delete them as well ?

x/staking/handler.go:63:                        tags.Action, ActionCompleteUnbonding,
x/staking/handler.go:79:                        tags.Action, tags.ActionCompleteRedelegation,
x/staking/tags/tags.go:12:      Action       = sdk.TagAction

[alexanderbez]

@fedekunze sorry, no begin/end blocker should keep their respective action tags iiuc. Also, CI is broken.

updated

[alessio]

ACK from me