Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/auth: tests #564

Closed
ebuchman opened this issue Mar 4, 2018 · 1 comment
Closed

x/auth: tests #564

ebuchman opened this issue Mar 4, 2018 · 1 comment
Assignees
@sunnya97
Labels
T: Tests
Milestone
100% Test Coverage

Comments

@ebuchman
Copy link
Member

ebuchman commented Mar 4, 2018

This package has virtually no tests despite having critical functionality:

ethanbuchman:auth$ go test -cover
PASS
coverage: 10.2% of statements
ok      github.com/cosmos/cosmos-sdk/x/auth     0.018s

We need a mapper_test.go to fully test the accountMapper and an ante_test.go to fully test the AnteHandler logic.
@martindale martindale added this to the 100% Test Coverage milestone Mar 8, 2018
@ebuchman
Copy link
Member Author

Test coverage here is now over 80% :D
See a lot of the work done in #615

yihuang added a commit to yihuang/cosmos-sdk that referenced this issue Jul 12, 2024
@yihuang
Problem: signature verification result not cache between incarnations of
45b23bd 
same tx

Closes: cosmos#564

Solution:
- introduce incarnation cache that's shared between incarnations of the
  same tx
yihuang added a commit to yihuang/cosmos-sdk that referenced this issue Jul 15, 2024
@yihuang
Problem: signature verification result not cache between incarnations…
5a1594f 
… of same tx (cosmos#565)

* Problem: signature verification result not cache between incarnations of
same tx

Closes: cosmos#564

Solution:
- introduce incarnation cache that's shared between incarnations of the
  same tx

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* fix nil convert

---------

Signed-off-by: yihuang <huang@crypto.com>
dudong2 pushed a commit to b-harvest/cosmos-sdk that referenced this issue Oct 17, 2024
@yihuang @dudong2
Problem: signature verification result not cache between incarnations…
735d2f6 
… of same tx (cosmos#565)

* Problem: signature verification result not cache between incarnations of
same tx

Closes: cosmos#564

Solution:
- introduce incarnation cache that's shared between incarnations of the
  same tx

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* fix nil convert

---------

Signed-off-by: yihuang <huang@crypto.com>
dudong2 pushed a commit to b-harvest/cosmos-sdk that referenced this issue Oct 30, 2024
@yihuang @dudong2
Problem: signature verification result not cache between incarnations…
10257ba 
… of same tx (cosmos#565)

* Problem: signature verification result not cache between incarnations of
same tx

Closes: cosmos#564

Solution:
- introduce incarnation cache that's shared between incarnations of the
  same tx

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* fix nil convert

---------

Signed-off-by: yihuang <huang@crypto.com>
dudong2 added a commit to b-harvest/cosmos-sdk that referenced this issue Nov 6, 2024
@dudong2 @yihuang
@mmsqe @cloudgray
feat: apply cronos (#208)
55e55e6 
* Problem: parallel tx execution is not supported (#205)

add basic support in sdk:
- add a TxExecutor baseapp option
- add TxIndex/TxCount/MsgIndex in context

Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

fix misspell

fix lint

run gci

fix lint

gci seems not compatible with gofumpt

* Support object store (#206)

generic interface

generic btree

generic cachekv

generic transient store

support ObjStore

changelog

Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

object store key

Apply review suggestions

fix merge conflict

fix snapshot

revert dependers

* prefix store support object store (#236)

* Problem: fee collection not compatible with parallel execution (#237)

* Problem: no efficient way to collect fee

Solution:
- support an idea of virtual account in bank module, where the incoming
  coins are accumulated in a per-tx object store first, then accumulate
  and credit to the real account at end blocker.

  it's nesserary to support parallel tx execution, where we try not to
  access shared states.

more efficient sum

support SendCoinsFromModuleToAccountVirtual

fix test

fix test

* fix lint

* fix test

* fix test

* fix test

* fix test

* fix test

* fix mock keeper

* try fix lint

* try fix lint

* reuse code

* try fix linter

* Update x/bank/keeper/send.go

Signed-off-by: yihuang <huang@crypto.com>

* algin panic call

* fix error handling

* try fix lint

* nolintlint generate falst postiive

---------

Signed-off-by: yihuang <huang@crypto.com>

* Problem: MultiStore interface is bloated (#240)

* Problem: MultiStore interface is bloated

Solution:
- Split out specialied methods from it, keeping the MultiStore generic

* Update store/CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

---------

Signed-off-by: yihuang <huang@crypto.com>

* Problem: no API to use the new CoW branch store (#243)

* Support RunAtomic API

* add unit test

* Problem: block gas used not set in context (#252)

Solution:
- fix the way context is updated

* Problem: invalid tx returns negative gas wanted (#253)

Solution:
- add checks

* Problem: signature verification result not cache between incarnations of same tx (cosmos#565)

* Problem: signature verification result not cache between incarnations of
same tx

Closes: cosmos#564

Solution:
- introduce incarnation cache that's shared between incarnations of the
  same tx

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* fix nil convert

---------

Signed-off-by: yihuang <huang@crypto.com>

* Problem: gas consumed differs after enabled cache (cosmos#570)

* Problem: gas consumed differs after enabled cache

* fix test

* Revert "Problem: gas consumed differs after enabled cache"

This reverts commit f33944e.

* Revert "Problem: signature verification result not cache between incarnations of same tx (cosmos#565)"

This reverts commit 5a1594f.

* keep interface

* Problem: tx executor can't do dependency analysis (cosmos#744)

* Problem: tx executor can't do dependency analysis

Solution:
- change the api to allow static analysis on tx body

* fix

* changelog

* cleanup

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

---------

Signed-off-by: yihuang <huang@crypto.com>

* Problem: can't extend abci listeners in streaming manager (#269)

Solution:
- add API StreamingManager to allow extending the abci listeners, mainly
  for versiondb support

Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

cleanup

* chore: apply custom-ed store

* feat: Append send restrictionto Delegate/Undelegate Coins (#202)

* chore: Update go.mod for custom store

* chore: fix lint

* chore: fix lint

* chore: Update go.mod for custom cosmos-sdk/store

* Revert "chore: fix lint"

This reverts commit 8e7af64.

---------

Signed-off-by: yihuang <huang@crypto.com>
Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: Kyuhyeon Choi <bluejet1104@gmail.com>
mmsqe pushed a commit to mmsqe/cosmos-sdk that referenced this issue Dec 12, 2024
@yihuang @mmsqe
Problem: signature verification result not cache between incarnations…
f6f23d0 
… of same tx (cosmos#565)

* Problem: signature verification result not cache between incarnations of
same tx

Closes: cosmos#564

Solution:
- introduce incarnation cache that's shared between incarnations of the
  same tx

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* fix nil convert

---------

Signed-off-by: yihuang <huang@crypto.com>
mmsqe pushed a commit to mmsqe/cosmos-sdk that referenced this issue Dec 12, 2024
@yihuang @mmsqe
Problem: signature verification result not cache between incarnations…
78bfe02 
… of same tx (cosmos#565)

* Problem: signature verification result not cache between incarnations of
same tx

Closes: cosmos#564

Solution:
- introduce incarnation cache that's shared between incarnations of the
  same tx

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* fix nil convert

---------

Signed-off-by: yihuang <huang@crypto.com>
mmsqe pushed a commit to mmsqe/cosmos-sdk that referenced this issue Dec 16, 2024
@yihuang @mmsqe
Problem: signature verification result not cache between incarnations…
b500712 
… of same tx (cosmos#565)

* Problem: signature verification result not cache between incarnations of
same tx

Closes: cosmos#564

Solution:
- introduce incarnation cache that's shared between incarnations of the
  same tx

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* fix nil convert

---------

Signed-off-by: yihuang <huang@crypto.com>
mmsqe pushed a commit to mmsqe/cosmos-sdk that referenced this issue Dec 16, 2024
@yihuang @mmsqe
Problem: signature verification result not cache between incarnations…
c20f59b 
… of same tx (cosmos#565)

* Problem: signature verification result not cache between incarnations of
same tx

Closes: cosmos#564

Solution:
- introduce incarnation cache that's shared between incarnations of the
  same tx

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* fix nil convert

---------

Signed-off-by: yihuang <huang@crypto.com>
dudong2 added a commit to b-harvest/cosmos-sdk that referenced this issue Dec 17, 2024
@dudong2 @yihuang
@mmsqe @cloudgray
feat: apply cronos (#208)
2b172f4 
* Problem: parallel tx execution is not supported (#205)

add basic support in sdk:
- add a TxExecutor baseapp option
- add TxIndex/TxCount/MsgIndex in context

Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

fix misspell

fix lint

run gci

fix lint

gci seems not compatible with gofumpt

* Support object store (#206)

generic interface

generic btree

generic cachekv

generic transient store

support ObjStore

changelog

Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

object store key

Apply review suggestions

fix merge conflict

fix snapshot

revert dependers

* prefix store support object store (#236)

* Problem: fee collection not compatible with parallel execution (#237)

* Problem: no efficient way to collect fee

Solution:
- support an idea of virtual account in bank module, where the incoming
  coins are accumulated in a per-tx object store first, then accumulate
  and credit to the real account at end blocker.

  it's nesserary to support parallel tx execution, where we try not to
  access shared states.

more efficient sum

support SendCoinsFromModuleToAccountVirtual

fix test

fix test

* fix lint

* fix test

* fix test

* fix test

* fix test

* fix test

* fix mock keeper

* try fix lint

* try fix lint

* reuse code

* try fix linter

* Update x/bank/keeper/send.go

Signed-off-by: yihuang <huang@crypto.com>

* algin panic call

* fix error handling

* try fix lint

* nolintlint generate falst postiive

---------

Signed-off-by: yihuang <huang@crypto.com>

* Problem: MultiStore interface is bloated (#240)

* Problem: MultiStore interface is bloated

Solution:
- Split out specialied methods from it, keeping the MultiStore generic

* Update store/CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

---------

Signed-off-by: yihuang <huang@crypto.com>

* Problem: no API to use the new CoW branch store (#243)

* Support RunAtomic API

* add unit test

* Problem: block gas used not set in context (#252)

Solution:
- fix the way context is updated

* Problem: invalid tx returns negative gas wanted (#253)

Solution:
- add checks

* Problem: signature verification result not cache between incarnations of same tx (cosmos#565)

* Problem: signature verification result not cache between incarnations of
same tx

Closes: cosmos#564

Solution:
- introduce incarnation cache that's shared between incarnations of the
  same tx

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* fix nil convert

---------

Signed-off-by: yihuang <huang@crypto.com>

* Problem: gas consumed differs after enabled cache (cosmos#570)

* Problem: gas consumed differs after enabled cache

* fix test

* Revert "Problem: gas consumed differs after enabled cache"

This reverts commit f33944e.

* Revert "Problem: signature verification result not cache between incarnations of same tx (cosmos#565)"

This reverts commit 5a1594f.

* keep interface

* Problem: tx executor can't do dependency analysis (cosmos#744)

* Problem: tx executor can't do dependency analysis

Solution:
- change the api to allow static analysis on tx body

* fix

* changelog

* cleanup

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

---------

Signed-off-by: yihuang <huang@crypto.com>

* Problem: can't extend abci listeners in streaming manager (#269)

Solution:
- add API StreamingManager to allow extending the abci listeners, mainly
  for versiondb support

Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

cleanup

* chore: apply custom-ed store

* feat: Append send restrictionto Delegate/Undelegate Coins (#202)

* chore: Update go.mod for custom store

* chore: fix lint

* chore: fix lint

* chore: Update go.mod for custom cosmos-sdk/store

* Revert "chore: fix lint"

This reverts commit 8e7af64.

---------

Signed-off-by: yihuang <huang@crypto.com>
Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: Kyuhyeon Choi <bluejet1104@gmail.com>
mmsqe pushed a commit to mmsqe/cosmos-sdk that referenced this issue Dec 18, 2024
@yihuang @mmsqe
Problem: signature verification result not cache between incarnations…
cd5b28d 
… of same tx (cosmos#565)

* Problem: signature verification result not cache between incarnations of
same tx

Closes: cosmos#564

Solution:
- introduce incarnation cache that's shared between incarnations of the
  same tx

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* fix nil convert

---------

Signed-off-by: yihuang <huang@crypto.com>

Problem: gas consumed differs after enabled cache (cosmos#570)

* Problem: gas consumed differs after enabled cache

* fix test

* Revert "Problem: gas consumed differs after enabled cache"

This reverts commit f33944e.

* Revert "Problem: signature verification result not cache between incarnations of same tx (cosmos#565)"

This reverts commit 5a1594f.

* keep interface
dudong2 added a commit to b-harvest/cosmos-sdk that referenced this issue Dec 19, 2024
@dudong2 @yihuang
@mmsqe @cloudgray
feat: bump up v0.50.8 -> v0.50.11 (#381)
ec638fb 
* feat: Append send restrictionto Delegate/Undelegate Coins (#202)

* feat: apply cronos (#208)

* Problem: parallel tx execution is not supported (#205)

add basic support in sdk:
- add a TxExecutor baseapp option
- add TxIndex/TxCount/MsgIndex in context

Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

fix misspell

fix lint

run gci

fix lint

gci seems not compatible with gofumpt

* Support object store (#206)

generic interface

generic btree

generic cachekv

generic transient store

support ObjStore

changelog

Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

object store key

Apply review suggestions

fix merge conflict

fix snapshot

revert dependers

* prefix store support object store (#236)

* Problem: fee collection not compatible with parallel execution (#237)

* Problem: no efficient way to collect fee

Solution:
- support an idea of virtual account in bank module, where the incoming
  coins are accumulated in a per-tx object store first, then accumulate
  and credit to the real account at end blocker.

  it's nesserary to support parallel tx execution, where we try not to
  access shared states.

more efficient sum

support SendCoinsFromModuleToAccountVirtual

fix test

fix test

* fix lint

* fix test

* fix test

* fix test

* fix test

* fix test

* fix mock keeper

* try fix lint

* try fix lint

* reuse code

* try fix linter

* Update x/bank/keeper/send.go

Signed-off-by: yihuang <huang@crypto.com>

* algin panic call

* fix error handling

* try fix lint

* nolintlint generate falst postiive

---------

Signed-off-by: yihuang <huang@crypto.com>

* Problem: MultiStore interface is bloated (#240)

* Problem: MultiStore interface is bloated

Solution:
- Split out specialied methods from it, keeping the MultiStore generic

* Update store/CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

---------

Signed-off-by: yihuang <huang@crypto.com>

* Problem: no API to use the new CoW branch store (#243)

* Support RunAtomic API

* add unit test

* Problem: block gas used not set in context (#252)

Solution:
- fix the way context is updated

* Problem: invalid tx returns negative gas wanted (#253)

Solution:
- add checks

* Problem: signature verification result not cache between incarnations of same tx (cosmos#565)

* Problem: signature verification result not cache between incarnations of
same tx

Closes: cosmos#564

Solution:
- introduce incarnation cache that's shared between incarnations of the
  same tx

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* fix nil convert

---------

Signed-off-by: yihuang <huang@crypto.com>

* Problem: gas consumed differs after enabled cache (cosmos#570)

* Problem: gas consumed differs after enabled cache

* fix test

* Revert "Problem: gas consumed differs after enabled cache"

This reverts commit f33944e.

* Revert "Problem: signature verification result not cache between incarnations of same tx (cosmos#565)"

This reverts commit 5a1594f.

* keep interface

* Problem: tx executor can't do dependency analysis (cosmos#744)

* Problem: tx executor can't do dependency analysis

Solution:
- change the api to allow static analysis on tx body

* fix

* changelog

* cleanup

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

---------

Signed-off-by: yihuang <huang@crypto.com>

* Problem: can't extend abci listeners in streaming manager (#269)

Solution:
- add API StreamingManager to allow extending the abci listeners, mainly
  for versiondb support

Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

cleanup

* chore: apply custom-ed store

* feat: Append send restrictionto Delegate/Undelegate Coins (#202)

* chore: Update go.mod for custom store

* chore: fix lint

* chore: fix lint

* chore: Update go.mod for custom cosmos-sdk/store

* Revert "chore: fix lint"

This reverts commit 8e7af64.

---------

Signed-off-by: yihuang <huang@crypto.com>
Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: Kyuhyeon Choi <bluejet1104@gmail.com>

* chore: Use basechain/develop-v0.50.11-store/v1.1.1

---------

Signed-off-by: yihuang <huang@crypto.com>
Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: Kyuhyeon Choi <bluejet1104@gmail.com>
mmsqe pushed a commit to mmsqe/cosmos-sdk that referenced this issue Dec 31, 2024
@yihuang @mmsqe
Problem: signature verification result not cache between incarnations…
aaa9c18 
… of same tx (cosmos#565)

* Problem: signature verification result not cache between incarnations of
same tx

Closes: cosmos#564

Solution:
- introduce incarnation cache that's shared between incarnations of the
  same tx

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* fix nil convert

---------

Signed-off-by: yihuang <huang@crypto.com>

Problem: gas consumed differs after enabled cache (cosmos#570)

* Problem: gas consumed differs after enabled cache

* fix test

* Revert "Problem: gas consumed differs after enabled cache"

This reverts commit f33944e.

* Revert "Problem: signature verification result not cache between incarnations of same tx (cosmos#565)"

This reverts commit 5a1594f.

* keep interface
mmsqe pushed a commit to mmsqe/cosmos-sdk that referenced this issue Jan 9, 2025
@yihuang @mmsqe
Problem: signature verification result not cache between incarnations…
fc5c5b4 
… of same tx (cosmos#565)

* Problem: signature verification result not cache between incarnations of
same tx

Closes: cosmos#564

Solution:
- introduce incarnation cache that's shared between incarnations of the
  same tx

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* fix nil convert

---------

Signed-off-by: yihuang <huang@crypto.com>

Problem: gas consumed differs after enabled cache (cosmos#570)

* Problem: gas consumed differs after enabled cache

* fix test

* Revert "Problem: gas consumed differs after enabled cache"

This reverts commit f33944e.

* Revert "Problem: signature verification result not cache between incarnations of same tx (cosmos#565)"

This reverts commit 5a1594f.

* keep interface
mmsqe pushed a commit to mmsqe/cosmos-sdk that referenced this issue Jan 9, 2025
@yihuang @mmsqe
Problem: signature verification result not cache between incarnations…
6561a3c 
… of same tx (cosmos#565)

* Problem: signature verification result not cache between incarnations of
same tx

Closes: cosmos#564

Solution:
- introduce incarnation cache that's shared between incarnations of the
  same tx

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* fix nil convert

---------

Signed-off-by: yihuang <huang@crypto.com>

Problem: gas consumed differs after enabled cache (cosmos#570)

* Problem: gas consumed differs after enabled cache

* fix test

* Revert "Problem: gas consumed differs after enabled cache"

This reverts commit f33944e.

* Revert "Problem: signature verification result not cache between incarnations of same tx (cosmos#565)"

This reverts commit 5a1594f.

* keep interface
mmsqe pushed a commit to mmsqe/cosmos-sdk that referenced this issue Jan 9, 2025
@yihuang @mmsqe
Problem: signature verification result not cache between incarnations…
ec68706 
… of same tx (cosmos#565)

* Problem: signature verification result not cache between incarnations of
same tx

Closes: cosmos#564

Solution:
- introduce incarnation cache that's shared between incarnations of the
  same tx

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* Update types/context.go

Signed-off-by: yihuang <huang@crypto.com>

* fix nil convert

---------

Signed-off-by: yihuang <huang@crypto.com>

Problem: gas consumed differs after enabled cache (cosmos#570)

* Problem: gas consumed differs after enabled cache

* fix test

* Revert "Problem: gas consumed differs after enabled cache"

This reverts commit f33944e.

* Revert "Problem: signature verification result not cache between incarnations of same tx (cosmos#565)"

This reverts commit 5a1594f.

* keep interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunnya97 sunnya97

Labels
T: Tests
Projects
None yet
Milestone
100% Test Coverage
Development

No branches or pull requests
3 participants
@martindale @sunnya97 @ebuchman