How does app get ChainID? #565
Labels
Comments
|
It already gets it in the Header in Begin Block. |
|
That helps, but we need it right away if we want to be able to verify transactions before the first block! |
|
replaced by #661 |
yihuang
added a commit
to yihuang/cosmos-sdk
that referenced
this issue
Jul 15, 2024
… of same tx (cosmos#565) * Problem: signature verification result not cache between incarnations of same tx Closes: cosmos#564 Solution: - introduce incarnation cache that's shared between incarnations of the same tx * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * fix nil convert --------- Signed-off-by: yihuang <huang@crypto.com>
mmsqe
added a commit
to mmsqe/cosmos-sdk
that referenced
this issue
Jul 16, 2024
…rnations of same tx (cosmos#565)" This reverts commit 5a1594f.
mmsqe
added a commit
to mmsqe/cosmos-sdk
that referenced
this issue
Jul 17, 2024
* Problem: gas consumed differs after enabled cache * fix test * Revert "Problem: gas consumed differs after enabled cache" This reverts commit f33944e. * Revert "Problem: signature verification result not cache between incarnations of same tx (cosmos#565)" This reverts commit 5a1594f. * keep interface
mmsqe
added a commit
to mmsqe/cosmos-sdk
that referenced
this issue
Aug 7, 2024
…rnations of same tx (cosmos#565)" This reverts commit 5a1594f.
dudong2
pushed a commit
to b-harvest/cosmos-sdk
that referenced
this issue
Oct 17, 2024
… of same tx (cosmos#565) * Problem: signature verification result not cache between incarnations of same tx Closes: cosmos#564 Solution: - introduce incarnation cache that's shared between incarnations of the same tx * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * fix nil convert --------- Signed-off-by: yihuang <huang@crypto.com>
dudong2
pushed a commit
to b-harvest/cosmos-sdk
that referenced
this issue
Oct 30, 2024
… of same tx (cosmos#565) * Problem: signature verification result not cache between incarnations of same tx Closes: cosmos#564 Solution: - introduce incarnation cache that's shared between incarnations of the same tx * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * fix nil convert --------- Signed-off-by: yihuang <huang@crypto.com>
dudong2
pushed a commit
to b-harvest/cosmos-sdk
that referenced
this issue
Oct 30, 2024
* Problem: gas consumed differs after enabled cache * fix test * Revert "Problem: gas consumed differs after enabled cache" This reverts commit f33944e. * Revert "Problem: signature verification result not cache between incarnations of same tx (cosmos#565)" This reverts commit 5a1594f. * keep interface
dudong2
added a commit
to b-harvest/cosmos-sdk
that referenced
this issue
Nov 6, 2024
* Problem: parallel tx execution is not supported (#205) add basic support in sdk: - add a TxExecutor baseapp option - add TxIndex/TxCount/MsgIndex in context Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> fix misspell fix lint run gci fix lint gci seems not compatible with gofumpt * Support object store (#206) generic interface generic btree generic cachekv generic transient store support ObjStore changelog Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> object store key Apply review suggestions fix merge conflict fix snapshot revert dependers * prefix store support object store (#236) * Problem: fee collection not compatible with parallel execution (#237) * Problem: no efficient way to collect fee Solution: - support an idea of virtual account in bank module, where the incoming coins are accumulated in a per-tx object store first, then accumulate and credit to the real account at end blocker. it's nesserary to support parallel tx execution, where we try not to access shared states. more efficient sum support SendCoinsFromModuleToAccountVirtual fix test fix test * fix lint * fix test * fix test * fix test * fix test * fix test * fix mock keeper * try fix lint * try fix lint * reuse code * try fix linter * Update x/bank/keeper/send.go Signed-off-by: yihuang <huang@crypto.com> * algin panic call * fix error handling * try fix lint * nolintlint generate falst postiive --------- Signed-off-by: yihuang <huang@crypto.com> * Problem: MultiStore interface is bloated (#240) * Problem: MultiStore interface is bloated Solution: - Split out specialied methods from it, keeping the MultiStore generic * Update store/CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> --------- Signed-off-by: yihuang <huang@crypto.com> * Problem: no API to use the new CoW branch store (#243) * Support RunAtomic API * add unit test * Problem: block gas used not set in context (#252) Solution: - fix the way context is updated * Problem: invalid tx returns negative gas wanted (#253) Solution: - add checks * Problem: signature verification result not cache between incarnations of same tx (cosmos#565) * Problem: signature verification result not cache between incarnations of same tx Closes: cosmos#564 Solution: - introduce incarnation cache that's shared between incarnations of the same tx * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * fix nil convert --------- Signed-off-by: yihuang <huang@crypto.com> * Problem: gas consumed differs after enabled cache (cosmos#570) * Problem: gas consumed differs after enabled cache * fix test * Revert "Problem: gas consumed differs after enabled cache" This reverts commit f33944e. * Revert "Problem: signature verification result not cache between incarnations of same tx (cosmos#565)" This reverts commit 5a1594f. * keep interface * Problem: tx executor can't do dependency analysis (cosmos#744) * Problem: tx executor can't do dependency analysis Solution: - change the api to allow static analysis on tx body * fix * changelog * cleanup * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> --------- Signed-off-by: yihuang <huang@crypto.com> * Problem: can't extend abci listeners in streaming manager (#269) Solution: - add API StreamingManager to allow extending the abci listeners, mainly for versiondb support Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> cleanup * chore: apply custom-ed store * feat: Append send restrictionto Delegate/Undelegate Coins (#202) * chore: Update go.mod for custom store * chore: fix lint * chore: fix lint * chore: Update go.mod for custom cosmos-sdk/store * Revert "chore: fix lint" This reverts commit 8e7af64. --------- Signed-off-by: yihuang <huang@crypto.com> Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Kyuhyeon Choi <bluejet1104@gmail.com>
mmsqe
pushed a commit
to mmsqe/cosmos-sdk
that referenced
this issue
Dec 12, 2024
… of same tx (cosmos#565) * Problem: signature verification result not cache between incarnations of same tx Closes: cosmos#564 Solution: - introduce incarnation cache that's shared between incarnations of the same tx * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * fix nil convert --------- Signed-off-by: yihuang <huang@crypto.com>
mmsqe
added a commit
to mmsqe/cosmos-sdk
that referenced
this issue
Dec 12, 2024
* Problem: gas consumed differs after enabled cache * fix test * Revert "Problem: gas consumed differs after enabled cache" This reverts commit f33944e. * Revert "Problem: signature verification result not cache between incarnations of same tx (cosmos#565)" This reverts commit 5a1594f. * keep interface
mmsqe
pushed a commit
to mmsqe/cosmos-sdk
that referenced
this issue
Dec 12, 2024
… of same tx (cosmos#565) * Problem: signature verification result not cache between incarnations of same tx Closes: cosmos#564 Solution: - introduce incarnation cache that's shared between incarnations of the same tx * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * fix nil convert --------- Signed-off-by: yihuang <huang@crypto.com>
mmsqe
added a commit
to mmsqe/cosmos-sdk
that referenced
this issue
Dec 12, 2024
* Problem: gas consumed differs after enabled cache * fix test * Revert "Problem: gas consumed differs after enabled cache" This reverts commit f33944e. * Revert "Problem: signature verification result not cache between incarnations of same tx (cosmos#565)" This reverts commit 5a1594f. * keep interface
mmsqe
pushed a commit
to mmsqe/cosmos-sdk
that referenced
this issue
Dec 16, 2024
… of same tx (cosmos#565) * Problem: signature verification result not cache between incarnations of same tx Closes: cosmos#564 Solution: - introduce incarnation cache that's shared between incarnations of the same tx * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * fix nil convert --------- Signed-off-by: yihuang <huang@crypto.com>
mmsqe
added a commit
to mmsqe/cosmos-sdk
that referenced
this issue
Dec 16, 2024
* Problem: gas consumed differs after enabled cache * fix test * Revert "Problem: gas consumed differs after enabled cache" This reverts commit f33944e. * Revert "Problem: signature verification result not cache between incarnations of same tx (cosmos#565)" This reverts commit 5a1594f. * keep interface
mmsqe
pushed a commit
to mmsqe/cosmos-sdk
that referenced
this issue
Dec 16, 2024
… of same tx (cosmos#565) * Problem: signature verification result not cache between incarnations of same tx Closes: cosmos#564 Solution: - introduce incarnation cache that's shared between incarnations of the same tx * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * fix nil convert --------- Signed-off-by: yihuang <huang@crypto.com>
mmsqe
added a commit
to mmsqe/cosmos-sdk
that referenced
this issue
Dec 16, 2024
* Problem: gas consumed differs after enabled cache * fix test * Revert "Problem: gas consumed differs after enabled cache" This reverts commit f33944e. * Revert "Problem: signature verification result not cache between incarnations of same tx (cosmos#565)" This reverts commit 5a1594f. * keep interface
dudong2
added a commit
to b-harvest/cosmos-sdk
that referenced
this issue
Dec 17, 2024
* Problem: parallel tx execution is not supported (#205) add basic support in sdk: - add a TxExecutor baseapp option - add TxIndex/TxCount/MsgIndex in context Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> fix misspell fix lint run gci fix lint gci seems not compatible with gofumpt * Support object store (#206) generic interface generic btree generic cachekv generic transient store support ObjStore changelog Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> object store key Apply review suggestions fix merge conflict fix snapshot revert dependers * prefix store support object store (#236) * Problem: fee collection not compatible with parallel execution (#237) * Problem: no efficient way to collect fee Solution: - support an idea of virtual account in bank module, where the incoming coins are accumulated in a per-tx object store first, then accumulate and credit to the real account at end blocker. it's nesserary to support parallel tx execution, where we try not to access shared states. more efficient sum support SendCoinsFromModuleToAccountVirtual fix test fix test * fix lint * fix test * fix test * fix test * fix test * fix test * fix mock keeper * try fix lint * try fix lint * reuse code * try fix linter * Update x/bank/keeper/send.go Signed-off-by: yihuang <huang@crypto.com> * algin panic call * fix error handling * try fix lint * nolintlint generate falst postiive --------- Signed-off-by: yihuang <huang@crypto.com> * Problem: MultiStore interface is bloated (#240) * Problem: MultiStore interface is bloated Solution: - Split out specialied methods from it, keeping the MultiStore generic * Update store/CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> --------- Signed-off-by: yihuang <huang@crypto.com> * Problem: no API to use the new CoW branch store (#243) * Support RunAtomic API * add unit test * Problem: block gas used not set in context (#252) Solution: - fix the way context is updated * Problem: invalid tx returns negative gas wanted (#253) Solution: - add checks * Problem: signature verification result not cache between incarnations of same tx (cosmos#565) * Problem: signature verification result not cache between incarnations of same tx Closes: cosmos#564 Solution: - introduce incarnation cache that's shared between incarnations of the same tx * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * fix nil convert --------- Signed-off-by: yihuang <huang@crypto.com> * Problem: gas consumed differs after enabled cache (cosmos#570) * Problem: gas consumed differs after enabled cache * fix test * Revert "Problem: gas consumed differs after enabled cache" This reverts commit f33944e. * Revert "Problem: signature verification result not cache between incarnations of same tx (cosmos#565)" This reverts commit 5a1594f. * keep interface * Problem: tx executor can't do dependency analysis (cosmos#744) * Problem: tx executor can't do dependency analysis Solution: - change the api to allow static analysis on tx body * fix * changelog * cleanup * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> --------- Signed-off-by: yihuang <huang@crypto.com> * Problem: can't extend abci listeners in streaming manager (#269) Solution: - add API StreamingManager to allow extending the abci listeners, mainly for versiondb support Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> cleanup * chore: apply custom-ed store * feat: Append send restrictionto Delegate/Undelegate Coins (#202) * chore: Update go.mod for custom store * chore: fix lint * chore: fix lint * chore: Update go.mod for custom cosmos-sdk/store * Revert "chore: fix lint" This reverts commit 8e7af64. --------- Signed-off-by: yihuang <huang@crypto.com> Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Kyuhyeon Choi <bluejet1104@gmail.com>
mmsqe
pushed a commit
to mmsqe/cosmos-sdk
that referenced
this issue
Dec 18, 2024
… of same tx (cosmos#565) * Problem: signature verification result not cache between incarnations of same tx Closes: cosmos#564 Solution: - introduce incarnation cache that's shared between incarnations of the same tx * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * fix nil convert --------- Signed-off-by: yihuang <huang@crypto.com> Problem: gas consumed differs after enabled cache (cosmos#570) * Problem: gas consumed differs after enabled cache * fix test * Revert "Problem: gas consumed differs after enabled cache" This reverts commit f33944e. * Revert "Problem: signature verification result not cache between incarnations of same tx (cosmos#565)" This reverts commit 5a1594f. * keep interface
dudong2
added a commit
to b-harvest/cosmos-sdk
that referenced
this issue
Dec 19, 2024
* feat: Append send restrictionto Delegate/Undelegate Coins (#202) * feat: apply cronos (#208) * Problem: parallel tx execution is not supported (#205) add basic support in sdk: - add a TxExecutor baseapp option - add TxIndex/TxCount/MsgIndex in context Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> fix misspell fix lint run gci fix lint gci seems not compatible with gofumpt * Support object store (#206) generic interface generic btree generic cachekv generic transient store support ObjStore changelog Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> object store key Apply review suggestions fix merge conflict fix snapshot revert dependers * prefix store support object store (#236) * Problem: fee collection not compatible with parallel execution (#237) * Problem: no efficient way to collect fee Solution: - support an idea of virtual account in bank module, where the incoming coins are accumulated in a per-tx object store first, then accumulate and credit to the real account at end blocker. it's nesserary to support parallel tx execution, where we try not to access shared states. more efficient sum support SendCoinsFromModuleToAccountVirtual fix test fix test * fix lint * fix test * fix test * fix test * fix test * fix test * fix mock keeper * try fix lint * try fix lint * reuse code * try fix linter * Update x/bank/keeper/send.go Signed-off-by: yihuang <huang@crypto.com> * algin panic call * fix error handling * try fix lint * nolintlint generate falst postiive --------- Signed-off-by: yihuang <huang@crypto.com> * Problem: MultiStore interface is bloated (#240) * Problem: MultiStore interface is bloated Solution: - Split out specialied methods from it, keeping the MultiStore generic * Update store/CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> --------- Signed-off-by: yihuang <huang@crypto.com> * Problem: no API to use the new CoW branch store (#243) * Support RunAtomic API * add unit test * Problem: block gas used not set in context (#252) Solution: - fix the way context is updated * Problem: invalid tx returns negative gas wanted (#253) Solution: - add checks * Problem: signature verification result not cache between incarnations of same tx (cosmos#565) * Problem: signature verification result not cache between incarnations of same tx Closes: cosmos#564 Solution: - introduce incarnation cache that's shared between incarnations of the same tx * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * fix nil convert --------- Signed-off-by: yihuang <huang@crypto.com> * Problem: gas consumed differs after enabled cache (cosmos#570) * Problem: gas consumed differs after enabled cache * fix test * Revert "Problem: gas consumed differs after enabled cache" This reverts commit f33944e. * Revert "Problem: signature verification result not cache between incarnations of same tx (cosmos#565)" This reverts commit 5a1594f. * keep interface * Problem: tx executor can't do dependency analysis (cosmos#744) * Problem: tx executor can't do dependency analysis Solution: - change the api to allow static analysis on tx body * fix * changelog * cleanup * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> --------- Signed-off-by: yihuang <huang@crypto.com> * Problem: can't extend abci listeners in streaming manager (#269) Solution: - add API StreamingManager to allow extending the abci listeners, mainly for versiondb support Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> cleanup * chore: apply custom-ed store * feat: Append send restrictionto Delegate/Undelegate Coins (#202) * chore: Update go.mod for custom store * chore: fix lint * chore: fix lint * chore: Update go.mod for custom cosmos-sdk/store * Revert "chore: fix lint" This reverts commit 8e7af64. --------- Signed-off-by: yihuang <huang@crypto.com> Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Kyuhyeon Choi <bluejet1104@gmail.com> * chore: Use basechain/develop-v0.50.11-store/v1.1.1 --------- Signed-off-by: yihuang <huang@crypto.com> Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Kyuhyeon Choi <bluejet1104@gmail.com>
mmsqe
pushed a commit
to mmsqe/cosmos-sdk
that referenced
this issue
Dec 31, 2024
… of same tx (cosmos#565) * Problem: signature verification result not cache between incarnations of same tx Closes: cosmos#564 Solution: - introduce incarnation cache that's shared between incarnations of the same tx * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * fix nil convert --------- Signed-off-by: yihuang <huang@crypto.com> Problem: gas consumed differs after enabled cache (cosmos#570) * Problem: gas consumed differs after enabled cache * fix test * Revert "Problem: gas consumed differs after enabled cache" This reverts commit f33944e. * Revert "Problem: signature verification result not cache between incarnations of same tx (cosmos#565)" This reverts commit 5a1594f. * keep interface
mmsqe
pushed a commit
to mmsqe/cosmos-sdk
that referenced
this issue
Jan 9, 2025
… of same tx (cosmos#565) * Problem: signature verification result not cache between incarnations of same tx Closes: cosmos#564 Solution: - introduce incarnation cache that's shared between incarnations of the same tx * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * fix nil convert --------- Signed-off-by: yihuang <huang@crypto.com> Problem: gas consumed differs after enabled cache (cosmos#570) * Problem: gas consumed differs after enabled cache * fix test * Revert "Problem: gas consumed differs after enabled cache" This reverts commit f33944e. * Revert "Problem: signature verification result not cache between incarnations of same tx (cosmos#565)" This reverts commit 5a1594f. * keep interface
mmsqe
pushed a commit
to mmsqe/cosmos-sdk
that referenced
this issue
Jan 9, 2025
… of same tx (cosmos#565) * Problem: signature verification result not cache between incarnations of same tx Closes: cosmos#564 Solution: - introduce incarnation cache that's shared between incarnations of the same tx * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * fix nil convert --------- Signed-off-by: yihuang <huang@crypto.com> Problem: gas consumed differs after enabled cache (cosmos#570) * Problem: gas consumed differs after enabled cache * fix test * Revert "Problem: gas consumed differs after enabled cache" This reverts commit f33944e. * Revert "Problem: signature verification result not cache between incarnations of same tx (cosmos#565)" This reverts commit 5a1594f. * keep interface
mmsqe
pushed a commit
to mmsqe/cosmos-sdk
that referenced
this issue
Jan 9, 2025
… of same tx (cosmos#565) * Problem: signature verification result not cache between incarnations of same tx Closes: cosmos#564 Solution: - introduce incarnation cache that's shared between incarnations of the same tx * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * Update types/context.go Signed-off-by: yihuang <huang@crypto.com> * fix nil convert --------- Signed-off-by: yihuang <huang@crypto.com> Problem: gas consumed differs after enabled cache (cosmos#570) * Problem: gas consumed differs after enabled cache * fix test * Revert "Problem: gas consumed differs after enabled cache" This reverts commit f33944e. * Revert "Problem: signature verification result not cache between incarnations of same tx (cosmos#565)" This reverts commit 5a1594f. * keep interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Perhaps we need to move the Tendermint genesis file definition to ABCI and just pass that whole thing in with InitChain ?
We're already passing the validators and the appstatebytes. I can foresee the app needing other things like consensus params, genesis time, and obviously it already needs chainID (ie. see https://github.com/cosmos/cosmos-sdk/pull/563/files#diff-86e76ffe4ff75177a11e41e45ddd08abR155)
The text was updated successfully, but these errors were encountered: