Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: staking config #10988

Merged
merged 31 commits into from
Mar 22, 2022
Merged

feat: staking config #10988

merged 31 commits into from
Mar 22, 2022

Conversation

tac0turtle
Copy link
Member

Description

staking config to remove DefaultPowerReduction global.

I want to see if this would be accepted as its easier to document and show users how to do this.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

tac0turtle
tac0turtle commented Jan 20, 2022
View reviewed changes
simapp/app.go Outdated Show resolved Hide resolved
@tac0turtle tac0turtle marked this pull request as ready for review January 20, 2022 16:43
amaury1093
amaury1093 reviewed Jan 21, 2022
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this proposal, it removes the reliance on globals, and makes it explicit in app.go how to change it.

x/staking/keeper/common_test.go Outdated Show resolved Hide resolved
x/staking/common_test.go Show resolved Hide resolved
types/staking.go Outdated Show resolved Hide resolved
x/bank/keeper/grpc_query_test.go Show resolved Hide resolved
x/feegrant/simulation/operations_test.go Outdated Show resolved Hide resolved
amaury1093
amaury1093 approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm okay with this change, pending an API-breaking changelog

Edit: I was trying to push for limiting the amount of API-breaking changes we make, but given how huge the current list already is, adding another one seems fine

@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Feb 3, 2022
@tac0turtle
Copy link
Member Author

im unable to reproduce the failing tests locally. it could be a ci thing? @AmauryM @atheeshp do you have time to help me?

@amaury1093 amaury1093 mentioned this pull request Mar 1, 2022
Merged
22 tasks
@atheeshp
Copy link
Contributor

atheeshp commented Mar 10, 2022 •
edited
Loading

im unable to reproduce the failing tests locally. it could be a ci thing? @AmauryM @atheeshp do you have time to help me?

Had a look on the failing tests, but couldn't find any clue for the cause. TestGetValidatorSortingMixed, TestTrackHistoricalInfo are failing with some non-determinism.

@mergify mergify bot merged commit 5e9656f into master Mar 22, 2022
@mergify mergify bot deleted the staking-config branch March 22, 2022 00:24
@amaury1093
Copy link
Contributor

I remember we had simulations issues on this PR. Then, we removed sims checks from PRs, and this got merged.

Just want to make sure we're still tracking those simulation errors somewhere.

@atheeshp atheeshp mentioned this pull request Mar 22, 2022
Merged
19 tasks
@tac0turtle
Copy link
Member Author

sims are passing now https://github.com/cosmos/cosmos-sdk/actions/runs/2023572586. the failing test was 03 on race and non, but now its passing

tac0turtle added a commit that referenced this pull request Mar 24, 2022
@tac0turtle
Revert "feat: staking config (#10988)"
e424871 
This reverts commit 5e9656f.
tac0turtle added a commit that referenced this pull request Mar 24, 2022
@tac0turtle
revert: Revert "feat: staking config (#10988)" (#11446)
66ca3e8 
* Revert "feat: staking config (#10988)"

This reverts commit 5e9656f.

* remove docs
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@tac0turtle
feat: staking config (cosmos#10988)
78b195e 
## Description

staking config to remove DefaultPowerReduction global. 

I want to see if this would be accepted as its easier to document and show users how to do this. 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@tac0turtle
revert: Revert "feat: staking config (cosmos#10988)" (cosmos#11446)
8ef4306 
* Revert "feat: staking config (cosmos#10988)"

This reverts commit 5e9656f.

* remove docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robert-zaremba robert-zaremba robert-zaremba left review comments

@amaury1093 amaury1093 amaury1093 approved these changes

@alexanderbez alexanderbez alexanderbez left review comments

@fedekunze fedekunze fedekunze approved these changes

@aaronc aaronc Awaiting requested review from aaronc

Assignees

@amaury1093 amaury1093

Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:Simulations C:x/auth C:x/bank C:x/evidence C:x/feegrant C:x/gov C:x/slashing C:x/staking
Projects
No open projects
Cosmos SDK: Core Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tac0turtle @atheeshp @amaury1093 @robert-zaremba @alexanderbez @fedekunze