Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: Revert "feat: staking config (#10988)" #11446

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Conversation

tac0turtle
Copy link
Member

This reverts commit 5e9656f.

Description

Reverting until the non-determinism can be solved. This is blocking other work from being merged


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle changed the title Revert "feat: staking config (#10988)" fix: Revert "feat: staking config (#10988)" Mar 24, 2022
@amaury1093 amaury1093 changed the title fix: Revert "feat: staking config (#10988)" revert: Revert "feat: staking config (#10988)" Mar 24, 2022
@tac0turtle tac0turtle merged commit 66ca3e8 into master Mar 24, 2022
@tac0turtle tac0turtle deleted the revert_stakingconfig branch March 24, 2022 11:26
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
* Revert "feat: staking config (cosmos#10988)"

This reverts commit 5e9656f.

* remove docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants