Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: consensus module #12905

Merged
merged 75 commits into from
Oct 5, 2022
Merged

feat: consensus module #12905

merged 75 commits into from
Oct 5, 2022

Conversation

tac0turtle
Copy link
Member

Description

Closes: #12652

Add consensus param module in line with deprecation of param module


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@fedekunze
Copy link
Collaborator

I'd call it consensus

@amaury1093
Copy link
Contributor

@marbar3778 : @JeancarloBarrios might hop into this PR to fix some stuff in the meantime while you're out.

@JeancarloBarrios
Copy link
Contributor

@marbar3778 : @JeancarloBarrios might hop into this PR to fix some stuff in the meantime while you're out.
I will keep the progress in this PR #13031

* remove lint error for accountkeeper and bankkeeper cant be nil

* regenerated protos with removing some unused imports

* add legacy exported + keeper and module dep inject functions
@github-actions github-actions bot added C:x/auth and removed C:CLI labels Aug 29, 2022

consensusParams := new(tmproto.ConsensusParams)

consensusParams.Version = &tmproto.VersionParams{AppVersion: 0}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marbar3778 I'm not sure how to handle the version for now I left the same value that is in default params, but maybe when you see this we can discuss it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would be the app version set by the upgrade module I believe. We may need to get it from there or leave it blank for now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left an empty struct. However, I'm reading through x/upgrade to check if I should bring it from there

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I just pass the upgrade keeper as a dependency?

x/auth/ante/ante.go Fixed Show fixed Hide fixed
x/auth/ante/ante.go Fixed Show resolved Hide resolved
Copy link
Member Author

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for pushing this over the finish line. I can add the docs in the morning to wrap it up then merge .

simapp/upgrades.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added the C:Rosetta Issues and PR related to Rosetta label Oct 4, 2022
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #12905 (f236fc2) into main (87e46b2) will decrease coverage by 0.09%.
The diff coverage is 19.58%.

❗ Current head f236fc2 differs from pull request most recent head a339f8f. Consider uploading reports for the commit a339f8f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12905      +/-   ##
==========================================
- Coverage   53.98%   53.89%   -0.10%     
==========================================
  Files         641      657      +16     
  Lines       55020    56650    +1630     
==========================================
+ Hits        29704    30531     +827     
- Misses      22934    23682     +748     
- Partials     2382     2437      +55     
Impacted Files Coverage Δ
baseapp/params_legacy.go 0.00% <0.00%> (ø)
x/consensus/keeper/msg_server.go 100.00% <ø> (ø)
x/params/module.go 22.41% <0.00%> (+0.74%) ⬆️
x/params/types/consensus_params_legacy.go 0.00% <ø> (ø)
x/staking/types/params_legacy.go 0.00% <ø> (ø)
x/upgrade/keeper/keeper.go 83.14% <ø> (ø)
simapp/upgrades.go 28.57% <36.36%> (ø)
baseapp/baseapp.go 75.06% <75.00%> (-1.58%) ⬇️
baseapp/grpcrouter.go 89.47% <100.00%> (-0.53%) ⬇️
simapp/app.go 77.84% <100.00%> (ø)
... and 18 more

@alexanderbez
Copy link
Contributor

I can wrap up the docs shortly

@tac0turtle
Copy link
Member Author

I can wrap up the docs shortly

added changelog and upgrading docs. We should merge and then we can follow up with a readme since this pr is already fairly large

@alexanderbez alexanderbez enabled auto-merge (squash) October 5, 2022 17:44
@alexanderbez alexanderbez merged commit 306a9a7 into main Oct 5, 2022
@alexanderbez alexanderbez deleted the marko/consensus_param branch October 5, 2022 18:06
Wryhder pushed a commit to Wryhder/cosmos-sdk that referenced this pull request Oct 26, 2022
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
tuantran1702 added a commit to cudoventures/cudos-node that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

module: consensus-param module
10 participants