Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: minor improvements to pr #13031

Merged

Conversation

JeancarloBarrios
Copy link
Contributor

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:CLI label Aug 25, 2022
@JeancarloBarrios JeancarloBarrios changed the title remove lint error for accountkeeper and bankkeeper cant be nil minor improvements to pr Aug 25, 2022
@JeancarloBarrios JeancarloBarrios mentioned this pull request Aug 25, 2022
19 tasks
@JeancarloBarrios JeancarloBarrios changed the title minor improvements to pr feat: minor improvements to pr Aug 25, 2022
@JeancarloBarrios JeancarloBarrios marked this pull request as ready for review August 29, 2022 16:24
@JeancarloBarrios JeancarloBarrios requested a review from a team as a code owner August 29, 2022 16:24
@JeancarloBarrios JeancarloBarrios merged commit bd70956 into marko/consensus_param Aug 29, 2022
@JeancarloBarrios JeancarloBarrios deleted the JeancarloBarrios/consensus_param branch August 29, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant