Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix make proto-gen #13564

Merged
merged 2 commits into from
Oct 17, 2022
Merged

fix: fix make proto-gen #13564

merged 2 commits into from
Oct 17, 2022

Conversation

julienrbrt
Copy link
Member

Description

Fixes make proto-gen for v0.45.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle merged commit a6e909e into release/v0.45.x Oct 17, 2022
@tac0turtle tac0turtle deleted the julien/fix-make-protogen branch October 17, 2022 14:42
SpicyLemon added a commit to provenance-io/cosmos-sdk that referenced this pull request Oct 24, 2022
@SpicyLemon @aaronc
@ValarDragon @julienrbrt @alexanderbez @nddeluca @mergify @gsk967
Apply v0.45.10 changes and prep changelog for v0.45.10-pio-1 (#318)
78cb115 
* fix: move ics23 to correct folder (cosmos#13549)

* fix: fix liveness tests cosmos#13551

* feat: add `GenSignedMockTx` (cosmos#13557)

* fix: fix `make proto-gen` (cosmos#13564)

* fix: fix `make proto-gen`

* add changelog

* feat: [REDO] gRPC query for operator and chain configuration (backport cosmos#13485) (cosmos#13589)

* chore: bump tendermint to `0.34.22` (cosmos#13585)

* fix: (v0.45.x) regression in return value of WithdrawDelegationRewards when rewards are zero (cosmos#13588)

* fix(server): v0.45.x Populate the PruningKeepEvery config entry in GetConfig. (cosmos#13610)

* Populate the PruningKeepEvery config entry in GetConfig.

* Update changlog.

* feat(cli): add module-account cli cmd and grpc get api (backport cosmos#13612) (cosmos#13617)

* feat(cli): add module-account cli cmd and grpc get api (cosmos#13612)

(cherry picked from commit ddf5cf0)

# Conflicts:
#	CHANGELOG.md
#	api/cosmos/auth/v1beta1/query.pulsar.go
#	api/cosmos/auth/v1beta1/query_grpc.pb.go
#	proto/cosmos/auth/v1beta1/query.proto
#	tests/e2e/auth/suite.go
#	x/auth/client/cli/query.go
#	x/auth/keeper/grpc_query.go
#	x/auth/keeper/grpc_query_test.go
#	x/auth/types/query.pb.go
#	x/auth/types/query.pb.gw.go

* update changelog

* fix conflicts

Co-authored-by: Sai Kumar <17549398+gsk967@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* chore: prepare 0.45.10 changelog (cosmos#13624)

* chore: prepare 0.45.10 changelog

* default release notes

* period

* Add missing changelog section for v0.45.9-pio-1.

* Remove the old release notes.

* Remove accidentally duplicated section for v0.45.4.

* Add new v0.45.10-pio-1 section to the changelog and update the release notes to reflect our stuff.

* Include a 'nothing' under unreleased.

* Add links to changlog entries.

Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Sai Kumar <17549398+gsk967@users.noreply.github.com>
jaybxyz pushed a commit to cosmosquad-labs/cosmos-sdk that referenced this pull request Nov 1, 2022
@julienrbrt @jaybxyz
fix: fix make proto-gen (cosmos#13564)
8bc5e6c 
* fix: fix `make proto-gen`

* add changelog

(cherry picked from commit a6e909e)
nnkken pushed a commit to likecoin/cosmos-sdk that referenced this pull request Nov 16, 2022
@julienrbrt @nnkken
fix: fix make proto-gen (cosmos#13564)
dc8d621 
* fix: fix `make proto-gen`

* add changelog
drklee3 pushed a commit to Kava-Labs/cosmos-sdk that referenced this pull request Feb 16, 2023
@julienrbrt @drklee3
fix: fix make proto-gen (cosmos#13564)
c617c87 
* fix: fix `make proto-gen`

* add changelog
@faddat faddat mentioned this pull request Dec 11, 2023
Draft
19 tasks
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
@julienrbrt @JeancarloBarrios
fix: fix make proto-gen (cosmos#13564)
8ac999d 
* fix: fix `make proto-gen`

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@aaronc aaronc Awaiting requested review from aaronc aaronc is a code owner

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
C:x/staking Type: Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienrbrt @tac0turtle