-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [REDO] gRPC query for operator and chain configuration (backport #13485) #13589
feat: [REDO] gRPC query for operator and chain configuration (backport #13485) #13589
Conversation
(cherry picked from commit c60c556) # Conflicts: # CHANGELOG.md # UPGRADING.md # api/cosmos/auth/v1beta1/query_grpc.pb.go # api/cosmos/bank/v1beta1/query.pulsar.go # runtime/app.go # server/start.go # simapp/app_legacy.go # x/auth/types/query.pb.go # x/bank/types/query.pb.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a upgrade.md entry
@tac0turtle we don't have an UPGRADING.md on 0.45.x :( Should I add one? |
CHANGELOG.md
Outdated
@@ -39,6 +39,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
|
|||
### Features | |||
|
|||
* (grpc) [#13485](https://github.com/cosmos/cosmos-sdk/pull/13485) Implement a new gRPC query, `/cosmos/base/node/v1beta1/config`, which provides operator configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have no upgrading, can we get a shot sentence on how to add this to user apps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. Updated 👍
@@ -0,0 +1,22 @@ | |||
syntax = "proto3"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add a since comment on the top of this file
* fix: move ics23 to correct folder (cosmos#13549) * fix: fix liveness tests cosmos#13551 * feat: add `GenSignedMockTx` (cosmos#13557) * fix: fix `make proto-gen` (cosmos#13564) * fix: fix `make proto-gen` * add changelog * feat: [REDO] gRPC query for operator and chain configuration (backport cosmos#13485) (cosmos#13589) * chore: bump tendermint to `0.34.22` (cosmos#13585) * fix: (v0.45.x) regression in return value of WithdrawDelegationRewards when rewards are zero (cosmos#13588) * fix(server): v0.45.x Populate the PruningKeepEvery config entry in GetConfig. (cosmos#13610) * Populate the PruningKeepEvery config entry in GetConfig. * Update changlog. * feat(cli): add module-account cli cmd and grpc get api (backport cosmos#13612) (cosmos#13617) * feat(cli): add module-account cli cmd and grpc get api (cosmos#13612) (cherry picked from commit ddf5cf0) # Conflicts: # CHANGELOG.md # api/cosmos/auth/v1beta1/query.pulsar.go # api/cosmos/auth/v1beta1/query_grpc.pb.go # proto/cosmos/auth/v1beta1/query.proto # tests/e2e/auth/suite.go # x/auth/client/cli/query.go # x/auth/keeper/grpc_query.go # x/auth/keeper/grpc_query_test.go # x/auth/types/query.pb.go # x/auth/types/query.pb.gw.go * update changelog * fix conflicts Co-authored-by: Sai Kumar <17549398+gsk967@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: prepare 0.45.10 changelog (cosmos#13624) * chore: prepare 0.45.10 changelog * default release notes * period * Add missing changelog section for v0.45.9-pio-1. * Remove the old release notes. * Remove accidentally duplicated section for v0.45.4. * Add new v0.45.10-pio-1 section to the changelog and update the release notes to reflect our stuff. * Include a 'nothing' under unreleased. * Add links to changlog entries. Co-authored-by: Aaron Craelius <aaron@regen.network> Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Sai Kumar <17549398+gsk967@users.noreply.github.com>
…cosmos#13485) (cosmos#13589) (cherry picked from commit 7a500a2)
Description
#13498 was reverted or removed on 0.45.x. In addition, it introduces a Go API breaking change.
This PR redoes #13498 but without the API breaking change 🎉
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change