Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: configure monorepo sonarcloud #13944

Merged
merged 10 commits into from
Nov 23, 2022
Merged

ci: configure monorepo sonarcloud #13944

merged 10 commits into from
Nov 23, 2022

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Nov 21, 2022 •
edited
Loading

Description

Closes: #13930

It is a bit annoying that we get one token per project.

  • TODO best to split the tests and build per projects

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added C:CLI C:Cosmovisor Issues and PR related to Cosmovisor C:Rosetta Issues and PR related to Rosetta Type: CI labels Nov 21, 2022
@tac0turtle
Copy link
Member

we should remove submodule testing if we have an action for all of them.

@julienrbrt julienrbrt closed this Nov 22, 2022
@julienrbrt julienrbrt reopened this Nov 22, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 22, 2022

[cosmos-sdk-simapp] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 7 Code Smells

50.1% 50.1% Coverage
2.3% 2.3% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Nov 22, 2022

[cosmos-sdk-client-v2] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Nov 22, 2022

[cosmos-sdk-errors] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Nov 22, 2022

[cosmos-sdk-core] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Nov 22, 2022

[cosmos-sdk-tools-rosetta] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julienrbrt julienrbrt marked this pull request as ready for review November 22, 2022 17:13
@julienrbrt julienrbrt requested a review from a team as a code owner November 22, 2022 17:13
@julienrbrt julienrbrt added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Nov 22, 2022
tac0turtle
tac0turtle approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need code coverage for simapp and the testing should be encapsulated in general testing if the sdk. Otherwise Lgtm

@julienrbrt
Copy link
Member Author

I don't think we need code coverage for simapp and the testing should be encapsulated in general testing if the sdk. Otherwise Lgtm

This makes sense. I will update. I need to add the integration tests and e2e tests actions in test.yml then.

@tac0turtle
Copy link
Member

I think integration and unit tests should cover coverage, e2e could duplicate lots of the below tests but it has tendermint added.

@tac0turtle
Copy link
Member

I think it might makes sense for the standalone items like rosetta cosmovisor and in the future other things to have their own code coverage, but not sure it makes sense something like math and errors have their own since they are internal to the sdk and directly used.

@julienrbrt
Copy link
Member Author

I think it might makes sense for the standalone items like rosetta cosmovisor and in the future other things to have their own code coverage, but not sure it makes sense something like math and errors have their own since they are internal to the sdk and directly used.

It is more about test coverage. I think it is good to strive to have all standalone go.mod well-tested, and not only because they are imported in the SDK.

@sonarcloud
Copy link

sonarcloud bot commented Nov 23, 2022

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julienrbrt
Copy link
Member Author

Added e2e and integration test coverage metrics into Cosmos SDK instead of standalone.

@github-actions github-actions bot removed the C:x/auth label Nov 23, 2022
@julienrbrt julienrbrt enabled auto-merge (squash) November 23, 2022 10:46
@julienrbrt julienrbrt merged commit ae91105 into main Nov 23, 2022
@julienrbrt julienrbrt deleted the julien/sonarcloud branch November 23, 2022 10:47
mergify bot pushed a commit that referenced this pull request Nov 23, 2022
@julienrbrt @mergify
ci: configure monorepo sonarcloud (#13944)
0af11da 
(cherry picked from commit ae91105)

# Conflicts:
#	.codecov.yml
#	.github/workflows/test.yml
#	sonar-project.properties
@mergify mergify bot mentioned this pull request Nov 23, 2022
Merged
@julienrbrt julienrbrt mentioned this pull request Nov 23, 2022
Merged
19 tasks
tac0turtle pushed a commit that referenced this pull request Nov 23, 2022
@mergify @julienrbrt
ci: configure monorepo sonarcloud (backport #13944) (#13985)
922962a 
* ci: configure monorepo sonarcloud (#13944)

(cherry picked from commit ae91105)

# Conflicts:
#	.codecov.yml
#	.github/workflows/test.yml
#	sonar-project.properties

* updates

* #13987

Co-authored-by: Julien Robert <julien@rbrt.fr>
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@julienrbrt
ci: configure monorepo sonarcloud (cosmos#13944)
9414f0a
@170210 170210 mentioned this pull request Jan 15, 2024
Open
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle Awaiting requested review from tac0turtle tac0turtle is a code owner

Assignees

@tac0turtle tac0turtle

Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release C:CLI C:Cosmovisor Issues and PR related to Cosmovisor C:Rosetta Issues and PR related to Rosetta Type: Build Type: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend SonarCloud configuration
2 participants
@julienrbrt @tac0turtle