Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve test skipping mechanism #13987

Merged
merged 1 commit into from
Nov 23, 2022
Merged

ci: improve test skipping mechanism #13987

merged 1 commit into from
Nov 23, 2022

Conversation

julienrbrt
Copy link
Member

Description

Follow-up of #13944.
The test-skip job takes precedence on the test.yml job while it should not.
Meaning all tests are skipped.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt marked this pull request as ready for review November 23, 2022 11:33
@julienrbrt julienrbrt requested a review from a team as a code owner November 23, 2022 11:33
@julienrbrt julienrbrt enabled auto-merge (squash) November 23, 2022 11:47
@julienrbrt julienrbrt changed the title ci: stop skipping tests ci: improve test skipping mechanism Nov 23, 2022
@julienrbrt julienrbrt enabled auto-merge (squash) November 23, 2022 13:28
@julienrbrt julienrbrt merged commit 2849050 into main Nov 23, 2022
@julienrbrt julienrbrt deleted the julien/test-skipped branch November 23, 2022 13:39
julienrbrt added a commit that referenced this pull request Nov 23, 2022
tac0turtle pushed a commit that referenced this pull request Nov 23, 2022
* ci: configure monorepo sonarcloud (#13944)

(cherry picked from commit ae91105)

# Conflicts:
#	.codecov.yml
#	.github/workflows/test.yml
#	sonar-project.properties

* updates

* #13987

Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants