Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: x/feegrant to stand alone #14649

Merged
merged 45 commits into from
Jan 25, 2023
Merged

refactor: x/feegrant to stand alone #14649

merged 45 commits into from
Jan 25, 2023

Conversation

atheeshp
Copy link
Contributor

Description

Closes: #14559

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@kocubinski kocubinski self-assigned this Jan 17, 2023
@amaury1093 amaury1093 self-assigned this Jan 18, 2023
@atheeshp atheeshp marked this pull request as ready for review January 19, 2023 06:16
@atheeshp atheeshp requested a review from a team as a code owner January 19, 2023 06:16
julienrbrt
julienrbrt reviewed Jan 19, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
simapp/go.mod Outdated Show resolved Hide resolved
tests/go.mod Outdated Show resolved Hide resolved
x/feegrant/go.mod Outdated Show resolved Hide resolved
x/feegrant/sonar-project.properties Show resolved Hide resolved
@julienrbrt julienrbrt mentioned this pull request Jan 19, 2023
Merged
@sonarcloud
Copy link

sonarcloud bot commented Jan 19, 2023

[Cosmos SDK - x/feegrant] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

julienrbrt
julienrbrt reviewed Jan 19, 2023
View reviewed changes
x/feegrant/go.mod Outdated
cosmossdk.io/depinject v1.0.0-alpha.3
cosmossdk.io/math v1.0.0-beta.4
github.com/cosmos/cosmos-proto v1.0.0-beta.1
github.com/cosmos/cosmos-sdk v0.46.7
Copy link
Member

@julienrbrt julienrbrt Jan 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use v0.47 instead of v0.46

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.47 is not releasted yet right? rc1 works?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, why not leaving the v0.46.0-beta2.0.2023_____ tags? These are pseudo version of main. I don't think we can use 0.46 or 0.47 due to the store refactor.

julienrbrt
julienrbrt reviewed Jan 20, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
julienrbrt
julienrbrt reviewed Jan 20, 2023
View reviewed changes
x/nft/go.mod Outdated Show resolved Hide resolved
@kocubinski kocubinski mentioned this pull request Jan 24, 2023
Merged
19 tasks
julienrbrt
julienrbrt reviewed Jan 25, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
julienrbrt
julienrbrt approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

likhita-809
likhita-809 approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing changelog file in feegrant and small nits, otherwise lgtm

UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
atheeshp and others added 4 commits January 25, 2023 14:54
@atheeshp
doc
2d401a1
@atheeshp
add changelog
61b6040
@atheeshp
Merge branch 'main' into ap/stand-alone-feegrant
baa07b6
@atheeshp @likhita-809
Update UPGRADING.md
58a2b19 
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
@atheeshp atheeshp added the A:automerge Automatically merge PR once all prerequisites pass. label Jan 25, 2023
@amaury1093
Copy link
Contributor

@kocubinski can you do another review, of lift your block?

@atheeshp atheeshp enabled auto-merge (squash) January 25, 2023 16:28
@atheeshp atheeshp merged commit cc10614 into main Jan 25, 2023
@atheeshp atheeshp deleted the ap/stand-alone-feegrant branch January 25, 2023 16:39
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@atheeshp @amaury1093 @likhita-809
refactor: x/feegrant to stand alone (cosmos#14649)
59d9aef 
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
@coderabbitai coderabbitai bot mentioned this pull request Apr 22, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez left review comments

@likhita-809 likhita-809 likhita-809 approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@kocubinski kocubinski kocubinski approved these changes

@amaury1093 amaury1093 Awaiting requested review from amaury1093

Assignees

@kocubinski kocubinski

@amaury1093 amaury1093

Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:Simulations C:x/feegrant C:x/staking Type: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: x/feegrant as a standalone go module
6 participants
@atheeshp @amaury1093 @kocubinski @alexanderbez @julienrbrt @likhita-809