-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rm dependency from x/auth -> x/feegrant #14755
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
"github.com/stretchr/testify/require" | ||
) | ||
|
||
func AssertError(t *testing.T, err error, expectedErr error, expectedErrMsg string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think bez meant here: https://github.com/cosmos/cosmos-sdk/blob/main/testutil/assertHelpers.go
If you end up moving this to this file, could you rename that file too :D
Description
Ref: #14649 (review), #14559
Removes the dependency on x/feegrant from x/auth. This is required for x/feegrant as a go module since it (like most modules) depends on x/auth.
ante
package instead of keeper interface infeegrant
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change